* [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro
@ 2021-04-14 15:56 Florent Revest
2021-04-14 18:57 ` Martin KaFai Lau
0 siblings, 1 reply; 4+ messages in thread
From: Florent Revest @ 2021-04-14 15:56 UTC (permalink / raw)
To: bpf; +Cc: ast, daniel, andrii, kpsingh, jackmanb, linux-kernel, Florent Revest
It is just missing a ';'. This macro is not used by any test yet.
Signed-off-by: Florent Revest <revest@chromium.org>
---
tools/testing/selftests/bpf/test_progs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_progs.h b/tools/testing/selftests/bpf/test_progs.h
index e87c8546230e..ee7e3b45182a 100644
--- a/tools/testing/selftests/bpf/test_progs.h
+++ b/tools/testing/selftests/bpf/test_progs.h
@@ -210,7 +210,7 @@ extern int test__join_cgroup(const char *path);
#define ASSERT_ERR_PTR(ptr, name) ({ \
static int duration = 0; \
const void *___res = (ptr); \
- bool ___ok = IS_ERR(___res) \
+ bool ___ok = IS_ERR(___res); \
CHECK(!___ok, (name), "unexpected pointer: %p\n", ___res); \
___ok; \
})
--
2.31.1.295.g9ea45b61b8-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro
2021-04-14 15:56 [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro Florent Revest
@ 2021-04-14 18:57 ` Martin KaFai Lau
2021-04-15 0:28 ` Andrii Nakryiko
0 siblings, 1 reply; 4+ messages in thread
From: Martin KaFai Lau @ 2021-04-14 18:57 UTC (permalink / raw)
To: Florent Revest; +Cc: bpf, ast, daniel, andrii, kpsingh, jackmanb, linux-kernel
On Wed, Apr 14, 2021 at 05:56:32PM +0200, Florent Revest wrote:
> It is just missing a ';'. This macro is not used by any test yet.
>
> Signed-off-by: Florent Revest <revest@chromium.org>
Fixes: 22ba36351631 ("selftests/bpf: Move and extend ASSERT_xxx() testing macros")
Since it has not been used, it could be bpf-next. Please also tag
it in the future.
Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro
2021-04-14 18:57 ` Martin KaFai Lau
@ 2021-04-15 0:28 ` Andrii Nakryiko
2021-04-15 8:48 ` Florent Revest
0 siblings, 1 reply; 4+ messages in thread
From: Andrii Nakryiko @ 2021-04-15 0:28 UTC (permalink / raw)
To: Martin KaFai Lau
Cc: Florent Revest, bpf, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, KP Singh, Brendan Jackman, open list
On Wed, Apr 14, 2021 at 11:58 AM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Wed, Apr 14, 2021 at 05:56:32PM +0200, Florent Revest wrote:
> > It is just missing a ';'. This macro is not used by any test yet.
> >
> > Signed-off-by: Florent Revest <revest@chromium.org>
> Fixes: 22ba36351631 ("selftests/bpf: Move and extend ASSERT_xxx() testing macros")
>
Thanks, Martin. Added Fixes tag and applied to bpf-next.
> Since it has not been used, it could be bpf-next. Please also tag
> it in the future.
>
> Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro
2021-04-15 0:28 ` Andrii Nakryiko
@ 2021-04-15 8:48 ` Florent Revest
0 siblings, 0 replies; 4+ messages in thread
From: Florent Revest @ 2021-04-15 8:48 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: Martin KaFai Lau, bpf, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, KP Singh, Brendan Jackman, open list
On Thu, Apr 15, 2021 at 2:28 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
> On Wed, Apr 14, 2021 at 11:58 AM Martin KaFai Lau <kafai@fb.com> wrote:
> > On Wed, Apr 14, 2021 at 05:56:32PM +0200, Florent Revest wrote:
> > > It is just missing a ';'. This macro is not used by any test yet.
> > >
> > > Signed-off-by: Florent Revest <revest@chromium.org>
> > Fixes: 22ba36351631 ("selftests/bpf: Move and extend ASSERT_xxx() testing macros")
> >
>
> Thanks, Martin. Added Fixes tag and applied to bpf-next.
>
> > Since it has not been used, it could be bpf-next. Please also tag
> > it in the future.
Sorry about that, I'll make sure I remember it next time :)
> > Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-15 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 15:56 [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro Florent Revest
2021-04-14 18:57 ` Martin KaFai Lau
2021-04-15 0:28 ` Andrii Nakryiko
2021-04-15 8:48 ` Florent Revest
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).