From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A00C433F5 for ; Mon, 28 Mar 2022 22:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiC1WN2 (ORCPT ); Mon, 28 Mar 2022 18:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiC1WNZ (ORCPT ); Mon, 28 Mar 2022 18:13:25 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3332B35843; Mon, 28 Mar 2022 15:02:01 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id z7so18864960iom.1; Mon, 28 Mar 2022 15:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zku73QpalQjK7mBNfRnqmkOyZliZDHv6CNwYX93bSZc=; b=W+nx2Rs6t4ExOmIqnQeOQD4iJiAsZfVSjiPnDOEoC/PKN0duaeeK+1RfeOBQOF0bYR zIVxDalhLdptimGuGHIEcTFR8MpB8preZuosCSp+LNTX5eHhwGbdhODb9JTnZcLPuT1I QLOMdrrNMAqatCzNY/tm4cqE5mqSjVp0Q/Tu8PY7CF8uCnSmvjGF1mYwh7HEitLEIxWD sI6mZA/N2BW2IsplbUB42Bz0gdBt4R2fZZP1qMmENIuO5OiIC+b0U4MAt6670q1CDugT 6PPJTaNT+2GePra2dTPgvFff94DWcxW3cdhHlYkEX8UXDhvu6QOPGNs/qFv8HpxukLcj /I4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zku73QpalQjK7mBNfRnqmkOyZliZDHv6CNwYX93bSZc=; b=pdqIzV06jo8SuEFXfdXAT24GbBjOdrLTiH9csBtepeqvT1dJFRX/20EhU+1IKOX8AI w3Y1RbVevhUugNZnjbiytYwsbXj31mGKAVIE8EHewFtuAE7xoBFBl2lnmRX3sswsjbM0 5FNRlQgQdA/IA3Iu0jkTYwRatCbdVvrPakVJBW9yIk428y6K7VIGckMKxH1Be2bPECyN /F3ZPg1NhW3bqa0Q0SJ+3ct6VRMkBXKdKgaDJiwKisJdm+dsEmD9LWD4xx35y9AZ+uJp HDArddwVU7y8aZ3ymkYnYATSE2DHdpcFQq9kcmp46EngiMjefqTXQWm9/KOsdWKqwYxJ R7ZQ== X-Gm-Message-State: AOAM531DMSrArzbqz4JDBhWCNJIm30453f2DY9Tsq73GWJtIpRx/hhxY x61zTWerfb738B/jmIKuDYZNP5iQ6akyk5SH3KXWiT2m X-Google-Smtp-Source: ABdhPJyta6fjjW/oHgljQRh12/jOLrq4xulwQgvJrCe6paXK4K0lFuDYs3HHKwvHP2IIgblrMB9kJD1xtRWcuN06kfM= X-Received: by 2002:a05:6e02:1562:b0:2c9:cb97:9a4 with SMTP id k2-20020a056e02156200b002c9cb9709a4mr1324007ilu.71.1648503345774; Mon, 28 Mar 2022 14:35:45 -0700 (PDT) MIME-Version: 1.0 References: <20220318161528.1531164-1-benjamin.tissoires@redhat.com> <20220318161528.1531164-7-benjamin.tissoires@redhat.com> In-Reply-To: From: Andrii Nakryiko Date: Mon, 28 Mar 2022 14:35:34 -0700 Message-ID: Subject: Re: [PATCH bpf-next v3 06/17] HID: allow to change the report descriptor from an eBPF program To: Benjamin Tissoires Cc: Alexei Starovoitov , Greg KH , Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Jonathan Corbet , Tero Kristo , LKML , "open list:HID CORE LAYER" , Network Development , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 27, 2022 at 11:57 PM Benjamin Tissoires wrote: > > On Fri, Mar 25, 2022 at 6:00 PM Andrii Nakryiko > wrote: > > > > On Wed, Mar 23, 2022 at 9:08 AM Benjamin Tissoires > > wrote: > > > > > > Hi Alexei, > > > > > > On Tue, Mar 22, 2022 at 11:51 PM Alexei Starovoitov > > > wrote: > > > > > > > > On Fri, Mar 18, 2022 at 9:16 AM Benjamin Tissoires > > > > wrote: > > > > > > > > > > +u8 *hid_bpf_report_fixup(struct hid_device *hdev, u8 *rdesc, unsigned int *size) > > > > > +{ > > > > > + int ret; > > > > > + struct hid_bpf_ctx_kern ctx = { > > > > > + .type = HID_BPF_RDESC_FIXUP, > > > > > + .hdev = hdev, > > > > > + .size = *size, > > > > > + }; > > > > > + > > > > > + if (bpf_hid_link_empty(&hdev->bpf, BPF_HID_ATTACH_RDESC_FIXUP)) > > > > > + goto ignore_bpf; > > > > > + > > > > > + ctx.data = kmemdup(rdesc, HID_MAX_DESCRIPTOR_SIZE, GFP_KERNEL); > > > > > + if (!ctx.data) > > > > > + goto ignore_bpf; > > > > > + > > > > > + ctx.allocated_size = HID_MAX_DESCRIPTOR_SIZE; > > > > > + > > > > > + ret = hid_bpf_run_progs(hdev, &ctx); > > > > > + if (ret) > > > > > + goto ignore_bpf; > > > > > + > > > > > + if (ctx.size > ctx.allocated_size) > > > > > + goto ignore_bpf; > > > > > + > > > > > + *size = ctx.size; > > > > > + > > > > > + if (*size) { > > > > > + rdesc = krealloc(ctx.data, *size, GFP_KERNEL); > > > > > + } else { > > > > > + rdesc = NULL; > > > > > + kfree(ctx.data); > > > > > + } > > > > > + > > > > > + return rdesc; > > > > > + > > > > > + ignore_bpf: > > > > > + kfree(ctx.data); > > > > > + return kmemdup(rdesc, *size, GFP_KERNEL); > > > > > +} > > > > > + > > > > > int __init hid_bpf_module_init(void) > > > > > { > > > > > struct bpf_hid_hooks hooks = { > > > > > .hdev_from_fd = hid_bpf_fd_to_hdev, > > > > > .pre_link_attach = hid_bpf_pre_link_attach, > > > > > + .post_link_attach = hid_bpf_post_link_attach, > > > > > .array_detach = hid_bpf_array_detach, > > > > > }; > > > > > > > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > > > index 937fab7eb9c6..3182c39db006 100644 > > > > > --- a/drivers/hid/hid-core.c > > > > > +++ b/drivers/hid/hid-core.c > > > > > @@ -1213,7 +1213,8 @@ int hid_open_report(struct hid_device *device) > > > > > return -ENODEV; > > > > > size = device->dev_rsize; > > > > > > > > > > - buf = kmemdup(start, size, GFP_KERNEL); > > > > > + /* hid_bpf_report_fixup() ensures we work on a copy of rdesc */ > > > > > + buf = hid_bpf_report_fixup(device, start, &size); > > > > > > > > Looking at this patch and the majority of other patches... > > > > the code is doing a lot of work to connect HID side with bpf. > > > > At the same time the evolution of the patch series suggests > > > > that these hook points are not quite stable. More hooks and > > > > helpers are being added. > > > > It tells us that it's way too early to introduce a stable > > > > interface between HID and bpf. > > > > > > I understand that you might be under the impression that the interface > > > is changing a lot, but this is mostly due to my poor knowledge of all > > > the arcanes of eBPF. > > > The overall way HID-BPF works is to work on a single array, and we > > > should pretty much be sorted out. There are a couple of helpers to be > > > able to communicate with the device, but the API has been stable in > > > the kernel for those for quite some time now. > > > > > > The variations in the hooks is mostly because I don't know what is the > > > best representation we can use in eBPF for those, and the review > > > process is changing that. > > > > I think such a big feature as this one, especially that most BPF folks > > are (probably) not familiar with the HID subsystem in the kernel, > > would benefit from a bit of live discussion during BPF office hours. > > Do you think you can give a short overview of what you are trying to > > achieve with some background context on HID specifics at one of the > > next BPF office hours? We have a meeting scheduled every week on > > Thursday, 9am Pacific time. But people need to put their topic onto > > the agenda, otherwise the meeting is cancelled. See [0] for > > spreadsheet and links to Zoom meeting, agenda, etc. > > This sounds like a good idea. I just added my topic on the agenda and > will prepare some slides. > Great! Unfortunately I personally have a conflict this week and won't be able to attend, so I'll have to catch up somehow through word of mouth :( Next week's BPF office hours would be best, but I don't want to delay discussions just because of me. > Cheers, > Benjamin > > > > > [0] https://docs.google.com/spreadsheets/d/1LfrDXZ9-fdhvPEp_LHkxAMYyxxpwBXjywWa0AejEveU > > > > [...] > > >