From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Florent Revest <revest@chromium.org>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
KP Singh <kpsingh@kernel.org>,
Brendan Jackman <jackmanb@chromium.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 6/6] selftests/bpf: Add a series of tests for bpf_snprintf
Date: Fri, 26 Mar 2021 16:05:24 -0700 [thread overview]
Message-ID: <CAEf4Bzb1z2KOHsMTrSP2t3S0iT3UrYMAWsO1_OqD_EYMECsZ-w@mail.gmail.com> (raw)
In-Reply-To: <20210324022211.1718762-7-revest@chromium.org>
On Tue, Mar 23, 2021 at 7:23 PM Florent Revest <revest@chromium.org> wrote:
>
> This exercises most of the format specifiers when things go well.
>
> Signed-off-by: Florent Revest <revest@chromium.org>
> ---
Looks good. Please add a no-argument test case as well.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> .../selftests/bpf/prog_tests/snprintf.c | 65 +++++++++++++++++++
> .../selftests/bpf/progs/test_snprintf.c | 59 +++++++++++++++++
> 2 files changed, 124 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/snprintf.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_snprintf.c
>
[...]
> +
> +SEC("raw_tp/sys_enter")
> +int handler(const void *ctx)
> +{
> + /* Convenient values to pretty-print */
> + const __u8 ex_ipv4[] = {127, 0, 0, 1};
> + const __u8 ex_ipv6[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1};
> + const char str1[] = "str1";
> + const char longstr[] = "longstr";
> + extern const void schedule __ksym;
oh, fancy. I'd move it out of this function into global space, though,
to make it more apparent. I almost missed that it's a special one.
> +
> + /* Integer types */
> + num_ret = BPF_SNPRINTF(num_out, sizeof(num_out),
> + "%d %u %x %li %llu %lX",
> + -8, 9, 150, -424242, 1337, 0xDABBAD00);
> + /* IP addresses */
> + ip_ret = BPF_SNPRINTF(ip_out, sizeof(ip_out), "%pi4 %pI6",
> + &ex_ipv4, &ex_ipv6);
> + /* Symbol lookup formatting */
> + sym_ret = BPF_SNPRINTF(sym_out, sizeof(sym_out), "%ps %pS %pB",
> + &schedule, &schedule, &schedule);
> + /* Kernel pointers */
> + addr_ret = BPF_SNPRINTF(addr_out, sizeof(addr_out), "%pK %px %p",
> + 0, 0xFFFF00000ADD4E55, 0xFFFF00000ADD4E55);
> + /* Strings embedding */
> + str_ret = BPF_SNPRINTF(str_out, sizeof(str_out), "%s %+05s",
> + str1, longstr);
> + /* Overflow */
> + over_ret = BPF_SNPRINTF(over_out, sizeof(over_out), "%%overflow");
> +
> + return 0;
> +}
> +
> +char _license[] SEC("license") = "GPL";
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
next prev parent reply other threads:[~2021-03-26 23:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:22 [PATCH bpf-next v2 0/6] Add a snprintf eBPF helper Florent Revest
2021-03-24 2:22 ` [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf Florent Revest
2021-03-26 21:53 ` Andrii Nakryiko
2021-03-26 22:51 ` Andrii Nakryiko
2021-04-06 15:35 ` Florent Revest
2021-04-07 21:53 ` Andrii Nakryiko
2021-04-08 22:52 ` Florent Revest
2021-03-24 2:22 ` [PATCH bpf-next v2 2/6] bpf: Add a ARG_PTR_TO_CONST_STR argument type Florent Revest
2021-03-26 22:23 ` Andrii Nakryiko
2021-04-06 15:38 ` Florent Revest
2021-03-24 2:22 ` [PATCH bpf-next v2 3/6] bpf: Add a bpf_snprintf helper Florent Revest
2021-03-26 22:55 ` Andrii Nakryiko
2021-04-06 16:06 ` Florent Revest
2021-04-07 22:03 ` Andrii Nakryiko
2021-04-08 22:43 ` Florent Revest
2021-03-24 2:22 ` [PATCH bpf-next v2 4/6] libbpf: Initialize the bpf_seq_printf parameters array field by field Florent Revest
2021-03-26 23:01 ` Andrii Nakryiko
2021-04-06 15:42 ` Florent Revest
2021-03-24 2:22 ` [PATCH bpf-next v2 5/6] libbpf: Introduce a BPF_SNPRINTF helper macro Florent Revest
2021-03-26 23:02 ` Andrii Nakryiko
2021-03-24 2:22 ` [PATCH bpf-next v2 6/6] selftests/bpf: Add a series of tests for bpf_snprintf Florent Revest
2021-03-26 23:05 ` Andrii Nakryiko [this message]
2021-04-06 15:40 ` Florent Revest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzb1z2KOHsMTrSP2t3S0iT3UrYMAWsO1_OqD_EYMECsZ-w@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jackmanb@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=revest@chromium.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).