From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Wenbo Zhang <ethercflow@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: Fix ___bpf_kretprobe_args1(x) macro definition.
Date: Sun, 15 Mar 2020 10:23:45 -0700 [thread overview]
Message-ID: <CAEf4BzbOKM+o-BmwZDkixF6y3bY57ch3x8J1os1+GGUTKbC1uA@mail.gmail.com> (raw)
In-Reply-To: <20200315083252.22274-1-ethercflow@gmail.com>
On Sun, Mar 15, 2020 at 1:33 AM Wenbo Zhang <ethercflow@gmail.com> wrote:
>
> Use PT_REGS_RC instead of PT_REGS_RET to get ret currectly.
>
> Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
> ---
Thanks!
Fixes: df8ff35311c8 ("libbpf: Merge selftests' bpf_trace_helpers.h
into libbpf's bpf_tracing.h")
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/lib/bpf/bpf_tracing.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h
> index b0c9ae5c73b5..f3f3c3fb98cb 100644
> --- a/tools/lib/bpf/bpf_tracing.h
> +++ b/tools/lib/bpf/bpf_tracing.h
> @@ -390,7 +390,7 @@ ____##name(struct pt_regs *ctx, ##args)
>
> #define ___bpf_kretprobe_args0() ctx
> #define ___bpf_kretprobe_args1(x) \
> - ___bpf_kretprobe_args0(), (void *)PT_REGS_RET(ctx)
> + ___bpf_kretprobe_args0(), (void *)PT_REGS_RC(ctx)
> #define ___bpf_kretprobe_args(args...) \
> ___bpf_apply(___bpf_kretprobe_args, ___bpf_narg(args))(args)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-15 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 8:32 [PATCH] bpf: Fix ___bpf_kretprobe_args1(x) macro definition Wenbo Zhang
2020-03-15 17:23 ` Andrii Nakryiko [this message]
2020-03-17 18:59 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbOKM+o-BmwZDkixF6y3bY57ch3x8J1os1+GGUTKbC1uA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ethercflow@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).