From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jiri Olsa <jolsa@redhat.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Documentation: Add minimum pahole version
Date: Tue, 16 Nov 2021 10:21:19 -0800 [thread overview]
Message-ID: <CAEf4BzbOnpL-=2Xi1DOheUtzc-JG5FmHqdvs4B_+0OeaCTgY=w@mail.gmail.com> (raw)
In-Reply-To: <YZPQ6+u2wTHRfR+W@kernel.org>
On Tue, Nov 16, 2021 at 7:40 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> A report was made in https://github.com/acmel/dwarves/issues/26 about
> pahole not being listed in the process/changes.rst file as being needed
> for building the kernel, address that.
>
> Link: https://github.com/acmel/dwarves/issues/26
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Andrii Nakryiko <andrii@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: bpf@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> Documentation/process/changes.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
> index e35ab74a0f804b04..c45f167a1b6c02a4 100644
> --- a/Documentation/process/changes.rst
> +++ b/Documentation/process/changes.rst
> @@ -35,6 +35,7 @@ GNU make 3.81 make --version
> binutils 2.23 ld -v
> flex 2.5.35 flex --version
> bison 2.0 bison --version
> +pahole 1.16 pahole --version
> util-linux 2.10o fdformat --version
> kmod 13 depmod -V
> e2fsprogs 1.41.4 e2fsck -V
> @@ -108,6 +109,14 @@ Bison
> Since Linux 4.16, the build system generates parsers
> during build. This requires bison 2.0 or later.
>
> +pahole:
> +-------
> +
> +Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in
> +vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is
I'd probably emphasize a bit more that pahole is required only if
CONFIG_DEBUG_INFO_BTF is selected by moving "If CONFIG_DEBUG_INFO_BTF
is selected, " to the front. But either way looks good.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> +selected. This requires pahole v1.16 or later. It is found in the 'dwarves' or
> +'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/.
> +
> Perl
> ----
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-11-16 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 15:40 [PATCH 1/1] Documentation: Add minimum pahole version Arnaldo Carvalho de Melo
2021-11-16 18:21 ` Andrii Nakryiko [this message]
2021-11-17 22:33 ` Daniel Borkmann
2021-11-18 13:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzbOnpL-=2Xi1DOheUtzc-JG5FmHqdvs4B_+0OeaCTgY=w@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).