Re: [PATCH v2] statx: stx_subvol

From: Neal Gompa <neal@gompa.dev>
To: Christian Brauner <brauner@kernel.org>
Cc: David Sterba <dsterba@suse.cz>,
	Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	 Kent Overstreet <kent.overstreet@linux.dev>,
	 "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	 "linux-bcachefs@vger.kernel.org"
	<linux-bcachefs@vger.kernel.org>,
	 "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Josef Bacik <josef@toxicpanda.com>,
	 Miklos Szeredi <mszeredi@redhat.com>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2] statx: stx_subvol
Date: Tue, 12 Mar 2024 10:17:40 -0700	[thread overview]
Message-ID: <CAEg-Je-XoSd_5HtBi8p7O8STB9_J4RZKKDtJqaQWtG_3vdbdRw@mail.gmail.com> (raw)
In-Reply-To: <20240312-ruhephase-belegen-d4ab0b192203@brauner>

On Tue, Mar 12, 2024 at 7:27 AM Christian Brauner <brauner@kernel.org> wrote:
>
> On Mon, Mar 11, 2024 at 11:43:00PM +0100, David Sterba wrote:
> > On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote:
> > > On Mon, Mar 11, 2024 at 08:12:33AM +0000, Johannes Thumshirn wrote:
> > > > On 08.03.24 03:29, Kent Overstreet wrote:
> > > > > Add a new statx field for (sub)volume identifiers, as implemented by
> > > > > btrfs and bcachefs.
> > > > >
> > > > > This includes bcachefs support; we'll definitely want btrfs support as
> > > > > well.
> > > >
> > > > For btrfs you can add the following:
> > > >
> > > >
> > > >  From 82343b7cb2a947bca43234c443b9c22339367f68 Mon Sep 17 00:00:00 2001
> > > > From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > > > Date: Mon, 11 Mar 2024 09:09:36 +0100
> > > > Subject: [PATCH] btrfs: provide subvolume id for statx
> > > >
> > > > Add the inode's subvolume id to the newly proposed statx subvol field.
> > > >
> > > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > > > ---
> > >
> > > Thanks, will fold, once I hear from Josef.
> >
> > We're OK with it.
>
> Thanks!

Well, I guess I'm fine with the whole thing then if everyone else is.

Reviewed-by: Neal Gompa <neal@gompa.dev>

--
真実はいつも一つ！/ Always, there's only one truth!