From: "Li, Zhen-Hua" <lizhenhua.dev@gmail.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Cong Ding <dinggnu@gmail.com>, Benoit Cousson <b-cousson@ti.com>,
Aneesh V <aneesh@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memory: of_memory.c: remove unnecessary initialization
Date: Wed, 5 Dec 2012 15:26:36 +0800 [thread overview]
Message-ID: <CAEk7JKakQRPKEoi+vkF2KexB1d_G+BN-PZQT-QDNEeOrkVm0Vg@mail.gmail.com> (raw)
In-Reply-To: <50BE0CC3.7060800@ti.com>
Infact, your patch does remove an orl operation, but add a new "move" operation.
You can test such two functions:
int func1(int rm1, int rm2){
int i = 0;
i |= rm1;
i |= rm2;
}
and
int func(int rm1, int rm2){
int i;
i = rm1;
i |= rm2;
}
Use gcc to compile them to assemble with "-S" operation, and you will find it.
On Tue, Dec 4, 2012 at 10:46 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> On Tuesday 04 December 2012 07:25 PM, Grant Likely wrote:
>>
>> On Tue, Dec 4, 2012 at 11:44 AM, Santosh Shilimkar
>> <santosh.shilimkar@ti.com> wrote:
>>>
>>> On Tuesday 04 December 2012 04:56 PM, Cong Ding wrote:
>>>>
>>>>
>>>> the initialization of variable ret is unnecessary, we can remove it
>>>> while
>>>> save
>>>> one time "or" operation.
>>>>
>>>> Signed-off-by: Cong Ding <dinggnu@gmail.com>
>>>> ---
>>>
>>>
>>> Looks ok.
>>> Acked-by: Santosh Shilimkar<santosh.shilimkar@ti.com>
>>>
>>
>> Thanks for the patch, but I don't think it matters enough to apply it.
>> The existing code isn't wrong.
>>
> The patch was removing an additional operation and hence i didn't
> contest it. I agree with your comment though.
>
> Regards
> Santosh
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-12-05 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 11:26 [PATCH] memory: of_memory.c: remove unnecessary initialization Cong Ding
2012-12-04 11:44 ` Santosh Shilimkar
2012-12-04 13:55 ` Grant Likely
2012-12-04 14:46 ` Santosh Shilimkar
2012-12-05 7:26 ` Li, Zhen-Hua [this message]
2012-12-05 7:41 ` Li, Zhen-Hua
2012-12-05 10:06 ` Cong Ding
2012-12-24 9:00 ` Li, Zhen-Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEk7JKakQRPKEoi+vkF2KexB1d_G+BN-PZQT-QDNEeOrkVm0Vg@mail.gmail.com \
--to=lizhenhua.dev@gmail.com \
--cc=aneesh@ti.com \
--cc=b-cousson@ti.com \
--cc=dinggnu@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).