From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753130AbcCAUij (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 15:38:39 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:33322 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751017AbcCAUih (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 15:38:37 -0500
MIME-Version: 1.0
In-Reply-To: <20160301203015.GC1488@katana>
References: <1455810794-3188-1-git-send-email-daniel.baluta@intel.com>
	<1455810794-3188-9-git-send-email-daniel.baluta@intel.com>
	<20160301203015.GC1488@katana>
Date: Tue, 1 Mar 2016 22:38:35 +0200
X-Google-Sender-Auth: lfDbFsEiuXw2D2Y8iFvn30anOe8
Message-ID: <CAEnQRZBZyGwhheHz_Smo_5kv36fpenM9HD+ab-u1qsfko0mvQQ@mail.gmail.com>
Subject: Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback
From: Daniel Baluta <daniel.baluta@intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Daniel Baluta <daniel.baluta@intel.com>,
        Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-i2c@vger.kernel.org, Lucas De Marchi <lucas.demarchi@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Ge Gao <ggao@invensense.com>, Adriana Reus <adi.reus@gmail.com>,
        Crt Mori <cmo@melexis.com>, Michael Welling <mwelling@ieee.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 1, 2016 at 10:30 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote:
>> From: Adriana Reus <adriana.reus@intel.com>
>>
>> Add a check in i2c_mux_master_xfer before calling the select callback.
>> This is necessary so that NULL callbacks can be safely registered.
>>
>> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>
> Hmm, rather than supporting that in the core, I'd prefer to have the
> driver pass an empty function instead. Then, in the driver, we can have
> a comment explaining the special situation.

Agree. This seems a better idea forcing the user to explain the situation :).