From: Daniel Baluta <daniel.baluta@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
linux-remoteproc@vger.kernel.org,
Devicetree List <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shengjiu Wang <shengjiu.wang@gmail.com>
Subject: Re: [PATCH v4 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver
Date: Fri, 10 Sep 2021 15:51:44 +0300 [thread overview]
Message-ID: <CAEnQRZBi6pMbuHTJF4yNzX_Lh-pYZc3LTNuKVs5pk-hNS-OWMQ@mail.gmail.com> (raw)
In-Reply-To: <1631092255-25150-5-git-send-email-shengjiu.wang@nxp.com>
On Wed, Sep 8, 2021 at 12:39 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> As there are two drivers for DSP on i.MX, one is for sound open
> firmware, another is for remote processor framework. In order to
> distinguish two kinds of driver, defining different compatible strings.
>
> For remote proc driver, the properties firmware-name and fsl,dsp-ctrl
> are needed and the mailbox channel is different with SOF.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Acked-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++--
> 1 file changed, 75 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> index 7afc9f2be13a..51ea657f6d42 100644
> --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core
>
> maintainers:
> - Daniel Baluta <daniel.baluta@nxp.com>
> + - Shengjiu Wang <shengjiu.wang@nxp.com>
>
> description: |
> Some boards from i.MX8 family contain a DSP core used for
> @@ -19,6 +20,10 @@ properties:
> - fsl,imx8qxp-dsp
> - fsl,imx8qm-dsp
> - fsl,imx8mp-dsp
> + - fsl,imx8qxp-hifi4
> + - fsl,imx8qm-hifi4
> + - fsl,imx8mp-hifi4
> + - fsl,imx8ulp-hifi4
>
> reg:
> maxItems: 1
> @@ -28,37 +33,63 @@ properties:
> - description: ipg clock
> - description: ocram clock
> - description: core clock
> + - description: debug interface clock
> + - description: message unit clock
> + minItems: 3
> + maxItems: 5
>
> clock-names:
> items:
> - const: ipg
> - const: ocram
> - const: core
> + - const: debug
> + - const: mu
> + minItems: 3
> + maxItems: 5
>
> power-domains:
> description:
> List of phandle and PM domain specifier as documented in
> Documentation/devicetree/bindings/power/power_domain.txt
> + minItems: 1
> maxItems: 4
>
> mboxes:
> description:
> List of <&phandle type channel> - 2 channels for TXDB, 2 channels for RXDB
> + or - 1 channel for TX, 1 channel for RX, 1 channel for RXDB
> (see mailbox/fsl,mu.txt)
> + minItems: 3
> maxItems: 4
>
> mbox-names:
> - items:
> - - const: txdb0
> - - const: txdb1
> - - const: rxdb0
> - - const: rxdb1
> + oneOf:
> + - items:
> + - const: txdb0
> + - const: txdb1
> + - const: rxdb0
> + - const: rxdb1
> + - items:
> + - const: tx
> + - const: rx
> + - const: rxdb
>
> memory-region:
> description:
> phandle to a node describing reserved memory (System RAM memory)
> used by DSP (see bindings/reserved-memory/reserved-memory.txt)
> - maxItems: 1
> + minItems: 1
> + maxItems: 4
> +
> + firmware-name:
> + description: |
> + Default name of the firmware to load to the remote processor.
> +
> + fsl,dsp-ctrl:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to syscon block which provide access for processor enablement
>
> required:
> - compatible
> @@ -91,3 +122,41 @@ examples:
> mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>;
> memory-region = <&dsp_reserved>;
> };
> + - |
> + #include <dt-bindings/clock/imx8mp-clock.h>
> + dsp_reserved: dsp@92400000 {
> + reg = <0x92400000 0x1000000>;
> + no-map;
> + };
> + dsp_vdev0vring0: vdev0vring0@942f0000 {
> + reg = <0x942f0000 0x8000>;
> + no-map;
> + };
> + dsp_vdev0vring1: vdev0vring1@942f8000 {
> + reg = <0x942f8000 0x8000>;
> + no-map;
> + };
> + dsp_vdev0buffer: vdev0buffer@94300000 {
> + compatible = "shared-dma-pool";
> + reg = <0x94300000 0x100000>;
> + no-map;
> + };
> +
> + dsp: dsp@3b6e8000 {
> + compatible = "fsl,imx8mp-hifi4";
> + reg = <0x3B6E8000 0x88000>;
> + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_DSP_ROOT>,
> + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_OCRAMA_IPG>,
> + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_DSP_ROOT>,
> + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_DSPDBG_ROOT>;
> + clock-names = "ipg", "ocram", "core", "debug";
> + firmware-name = "imx/dsp/hifi4.bin";
> + power-domains = <&audiomix_pd>;
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&mu2 0 0>,
> + <&mu2 1 0>,
> + <&mu2 3 0>;
> + memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> + <&dsp_vdev0vring1>, <&dsp_reserved>;
> + fsl,dsp-ctrl = <&audio_blk_ctrl>;
> + };
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-10 12:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 9:10 [PATCH v4 0/4] Add remoteproc driver for DSP on i.MX Shengjiu Wang
2021-09-08 9:10 ` [PATCH v4 1/4] remoteproc: imx_rproc: Move common structure to header file Shengjiu Wang
2021-09-14 17:46 ` Mathieu Poirier
2021-09-08 9:10 ` [PATCH v4 2/4] remoteproc: imx_rproc: Add IMX_RPROC_SCU_API method Shengjiu Wang
2021-09-14 17:47 ` Mathieu Poirier
2021-09-08 9:10 ` [PATCH v4 3/4] remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX Shengjiu Wang
2021-09-14 17:56 ` Mathieu Poirier
2021-09-15 3:09 ` Shengjiu Wang
2021-09-15 16:16 ` Mathieu Poirier
2021-09-16 10:44 ` Shengjiu Wang
2021-09-16 16:59 ` Mathieu Poirier
2021-09-17 5:20 ` Shengjiu Wang
2021-09-17 9:44 ` Shengjiu Wang
2021-09-17 15:22 ` Mathieu Poirier
2021-09-22 1:35 ` Shengjiu Wang
2021-09-22 17:55 ` Mathieu Poirier
2021-09-23 1:48 ` Shengjiu Wang
2021-09-16 17:23 ` Mathieu Poirier
2021-09-17 6:04 ` Shengjiu Wang
2021-09-08 9:10 ` [PATCH v4 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver Shengjiu Wang
2021-09-10 12:51 ` Daniel Baluta [this message]
2021-09-10 21:43 ` Rob Herring
2021-09-13 2:49 ` Shengjiu Wang
2021-09-13 17:08 ` Mathieu Poirier
2021-09-14 11:45 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZBi6pMbuHTJF4yNzX_Lh-pYZc3LTNuKVs5pk-hNS-OWMQ@mail.gmail.com \
--to=daniel.baluta@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).