From: Daniel Baluta <daniel.baluta@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"angus@akkea.ca" <angus@akkea.ca>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
Abel Vesa <abel.vesa@nxp.com>,
"ccaione@baylibre.com" <ccaione@baylibre.com>,
"baruch@tkos.co.il" <baruch@tkos.co.il>,
"agx@sigxcpu.org" <agx@sigxcpu.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>,
"spencercw@gmail.com" <spencercw@gmail.com>
Subject: Re: [PATCH v4 5/5] arm64: dts: imx8mq-evk: Enable wm8524 codec
Date: Fri, 8 Mar 2019 13:52:12 +0200 [thread overview]
Message-ID: <CAEnQRZCwW-zqGRHwy8eUUDxFP2kYMpH6PJgSVZuZJCaFJrv+xA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5COQNvpbdxG808aRSfMhMHznorPzoCD-Kp7rB6e8jz4Ng@mail.gmail.com>
On Fri, Mar 8, 2019 at 12:32 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Daniel,
>
> On Fri, Mar 1, 2019 at 12:53 PM Daniel Baluta <daniel.baluta@gmail.com> wrote:
>
> > They are used by simple-card.c machine driver.
> >
> > asoc_simple_card_parse_clk
> > -> /* Parse dai->sysclk come from "clocks = <&xxx>" */
> > clk = devm_get_clk_from_child(dev, node, NULL);
>
> The simple-card looks for the "clocks" properties inside the
> simple-card node, not inside the codec node, right?
I see your point now.
Indeed, "clocks" properties is the one inside simple-card.
sound-wm8524 {
compatible = "simple-audio-card";
link_codec: simple-audio-card,codec {
sound-dai = <&wm8524>;
clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
Will remove them from wm8524: audio-codec node because
they are useless there.
thanks,
Daniel.
prev parent reply other threads:[~2019-03-08 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 6:38 [PATCH v4 0/5] Enable wm8524 on i.MX8MQ-EVK Daniel Baluta
2019-02-27 6:38 ` [PATCH v4 1/5] arm64: dts: imx8mq: Add SDMA nodes Daniel Baluta
2019-02-28 18:29 ` Fabio Estevam
2019-02-27 6:38 ` [PATCH v4 2/5] bindings: fsl-imx-sdma: Document fsl,imx8mq-sdma compatbile string Daniel Baluta
2019-02-28 14:31 ` Rob Herring
2019-02-27 6:38 ` [PATCH v4 3/5] arm64: dts: imx8mq: Add SAI2 node Daniel Baluta
2019-02-28 18:31 ` Fabio Estevam
2019-03-01 12:25 ` Daniel Baluta
2019-02-27 6:38 ` [PATCH v4 4/5] arm64: dts: imx8mq-evk: Enable " Daniel Baluta
2019-02-27 6:38 ` [PATCH v4 5/5] arm64: dts: imx8mq-evk: Enable wm8524 codec Daniel Baluta
2019-02-28 18:40 ` Fabio Estevam
2019-03-01 15:53 ` Daniel Baluta
2019-03-08 10:32 ` Fabio Estevam
2019-03-08 11:52 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZCwW-zqGRHwy8eUUDxFP2kYMpH6PJgSVZuZJCaFJrv+xA@mail.gmail.com \
--to=daniel.baluta@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=aisheng.dong@nxp.com \
--cc=angus@akkea.ca \
--cc=baruch@tkos.co.il \
--cc=ccaione@baylibre.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=spencercw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).