* [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
@ 2019-07-28 14:12 Daniel Baluta
2019-07-28 14:53 ` Angus Ainslie
2019-07-29 8:31 ` Guido Günther
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Baluta @ 2019-07-28 14:12 UTC (permalink / raw)
To: shawnguo
Cc: s.hauer, festevam, linux-imx, l.stach, ccaione, abel.vesa,
baruch, andrew.smirnov, devicetree, linux-arm-kernel,
linux-kernel, shengjiu.wang, angus, agx, Anson.Huang,
Daniel Baluta
From: Abel Vesa <abel.vesa@nxp.com>
Add the initial configuration for clocks that need default parent and rate
setting. This is based on the vendor tree clock provider parents and rates
configuration except this is doing the setup in dts rather then using clock
consumer API in a clock provider driver.
Note that by adding the initial rate setting for audio_pll1/audio_pll
setting we need to remove it from imx8mq-librem5-devkit.dts
imx8mq-librem5-devkit.dts
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
Changes since v2:
- set rate for audio_pll1/audio_pll2 in the dtsi file and
remove the setting from imx8mq-librem5-devkit.dts
.../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 683a11035643..c702ccc82867 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -169,11 +169,6 @@
};
};
-&clk {
- assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
- assigned-clock-rates = <786432000>, <722534400>;
-};
-
&dphy {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 02fbd0625318..c67625a881a4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -494,6 +494,27 @@
clock-names = "ckil", "osc_25m", "osc_27m",
"clk_ext1", "clk_ext2",
"clk_ext3", "clk_ext4";
+ assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
+ <&clk IMX8MQ_AUDIO_PLL1>,
+ <&clk IMX8MQ_AUDIO_PLL2>,
+ <&clk IMX8MQ_CLK_AHB>,
+ <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
+ <&clk IMX8MQ_CLK_AUDIO_AHB>,
+ <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+ <&clk IMX8MQ_CLK_NOC>;
+ assigned-clock-parents = <0>,
+ <0>,
+ <0>,
+ <&clk IMX8MQ_SYS1_PLL_133M>,
+ <&clk IMX8MQ_SYS1_PLL_266M>,
+ <&clk IMX8MQ_SYS2_PLL_500M>,
+ <&clk IMX8MQ_CLK_27M>,
+ <&clk IMX8MQ_SYS1_PLL_800M>;
+ assigned-clock-rates = <593999999>,
+ <786432000>,
+ <722534400>;
+
+
};
src: reset-controller@30390000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
2019-07-28 14:12 [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks Daniel Baluta
@ 2019-07-28 14:53 ` Angus Ainslie
2019-07-28 15:25 ` Daniel Baluta
2019-07-29 8:31 ` Guido Günther
1 sibling, 1 reply; 5+ messages in thread
From: Angus Ainslie @ 2019-07-28 14:53 UTC (permalink / raw)
To: Daniel Baluta
Cc: shawnguo, s.hauer, festevam, linux-imx, l.stach, ccaione,
abel.vesa, baruch, andrew.smirnov, devicetree, linux-arm-kernel,
linux-kernel, shengjiu.wang, agx, Anson.Huang,
linux-kernel-owner
Hi Daniel,
On 2019-07-28 07:12, Daniel Baluta wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
>
> Add the initial configuration for clocks that need default parent and
> rate
> setting. This is based on the vendor tree clock provider parents and
> rates
> configuration except this is doing the setup in dts rather then using
> clock
> consumer API in a clock provider driver.
>
> Note that by adding the initial rate setting for audio_pll1/audio_pll
> setting we need to remove it from imx8mq-librem5-devkit.dts
> imx8mq-librem5-devkit.dts
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
This works with our board. One small nit below
Tested-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
> Changes since v2:
> - set rate for audio_pll1/audio_pll2 in the dtsi file and
> remove the setting from imx8mq-librem5-devkit.dts
>
> .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> 2 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 683a11035643..c702ccc82867 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -169,11 +169,6 @@
> };
> };
>
> -&clk {
> - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> - assigned-clock-rates = <786432000>, <722534400>;
> -};
> -
> &dphy {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 02fbd0625318..c67625a881a4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -494,6 +494,27 @@
> clock-names = "ckil", "osc_25m", "osc_27m",
> "clk_ext1", "clk_ext2",
> "clk_ext3", "clk_ext4";
> + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL2>,
> + <&clk IMX8MQ_CLK_AHB>,
> + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> + <&clk IMX8MQ_CLK_NOC>;
> + assigned-clock-parents = <0>,
> + <0>,
> + <0>,
> + <&clk IMX8MQ_SYS1_PLL_133M>,
> + <&clk IMX8MQ_SYS1_PLL_266M>,
> + <&clk IMX8MQ_SYS2_PLL_500M>,
> + <&clk IMX8MQ_CLK_27M>,
> + <&clk IMX8MQ_SYS1_PLL_800M>;
> + assigned-clock-rates = <593999999>,
> + <786432000>,
> + <722534400>;
> +
> +
Extra whitespace
Angus
> };
>
> src: reset-controller@30390000 {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
2019-07-28 14:53 ` Angus Ainslie
@ 2019-07-28 15:25 ` Daniel Baluta
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2019-07-28 15:25 UTC (permalink / raw)
To: Angus Ainslie
Cc: Daniel Baluta, Shawn Guo, Sascha Hauer, Fabio Estevam,
dl-linux-imx, Lucas Stach, Carlo Caione, Abel Vesa, baruch,
Andrey Smirnov, Devicetree List, linux-arm-kernel,
Linux Kernel Mailing List, S.j. Wang, Guido Günther,
Anson Huang, linux-kernel-owner
On Sun, Jul 28, 2019 at 5:53 PM Angus Ainslie <angus@akkea.ca> wrote:
>
> Hi Daniel,
>
> On 2019-07-28 07:12, Daniel Baluta wrote:
> > From: Abel Vesa <abel.vesa@nxp.com>
> >
> > Add the initial configuration for clocks that need default parent and
> > rate
> > setting. This is based on the vendor tree clock provider parents and
> > rates
> > configuration except this is doing the setup in dts rather then using
> > clock
> > consumer API in a clock provider driver.
> >
> > Note that by adding the initial rate setting for audio_pll1/audio_pll
> > setting we need to remove it from imx8mq-librem5-devkit.dts
> > imx8mq-librem5-devkit.dts
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
>
> This works with our board. One small nit below
>
> Tested-by: Angus Ainslie (Purism) <angus@akkea.ca>
>
> > ---
> > Changes since v2:
> > - set rate for audio_pll1/audio_pll2 in the dtsi file and
> > remove the setting from imx8mq-librem5-devkit.dts
> >
> > .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> > 2 files changed, 21 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..c702ccc82867 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -169,11 +169,6 @@
> > };
> > };
> >
> > -&clk {
> > - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> > - assigned-clock-rates = <786432000>, <722534400>;
> > -};
> > -
> > &dphy {
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 02fbd0625318..c67625a881a4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -494,6 +494,27 @@
> > clock-names = "ckil", "osc_25m", "osc_27m",
> > "clk_ext1", "clk_ext2",
> > "clk_ext3", "clk_ext4";
> > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL2>,
> > + <&clk IMX8MQ_CLK_AHB>,
> > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> > + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> > + <&clk IMX8MQ_CLK_NOC>;
> > + assigned-clock-parents = <0>,
> > + <0>,
> > + <0>,
> > + <&clk IMX8MQ_SYS1_PLL_133M>,
> > + <&clk IMX8MQ_SYS1_PLL_266M>,
> > + <&clk IMX8MQ_SYS2_PLL_500M>,
> > + <&clk IMX8MQ_CLK_27M>,
> > + <&clk IMX8MQ_SYS1_PLL_800M>;
> > + assigned-clock-rates = <593999999>,
> > + <786432000>,
> > + <722534400>;
> > +
> > +
>
> Extra whitespace
Thanks Angus for testing. Fixed in v4.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
2019-07-28 14:12 [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks Daniel Baluta
2019-07-28 14:53 ` Angus Ainslie
@ 2019-07-29 8:31 ` Guido Günther
2019-07-29 9:03 ` Daniel Baluta
1 sibling, 1 reply; 5+ messages in thread
From: Guido Günther @ 2019-07-29 8:31 UTC (permalink / raw)
To: Daniel Baluta
Cc: shawnguo, s.hauer, festevam, linux-imx, l.stach, ccaione,
abel.vesa, baruch, andrew.smirnov, devicetree, linux-arm-kernel,
linux-kernel, shengjiu.wang, angus, Anson.Huang
Hi,
On Sun, Jul 28, 2019 at 05:12:18PM +0300, Daniel Baluta wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
>
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather then using clock
> consumer API in a clock provider driver.
>
> Note that by adding the initial rate setting for audio_pll1/audio_pll
> setting we need to remove it from imx8mq-librem5-devkit.dts
> imx8mq-librem5-devkit.dts
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Changes since v2:
> - set rate for audio_pll1/audio_pll2 in the dtsi file and
> remove the setting from imx8mq-librem5-devkit.dts
>
> .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> 2 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 683a11035643..c702ccc82867 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -169,11 +169,6 @@
> };
> };
>
> -&clk {
> - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> - assigned-clock-rates = <786432000>, <722534400>;
> -};
> -
> &dphy {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 02fbd0625318..c67625a881a4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -494,6 +494,27 @@
> clock-names = "ckil", "osc_25m", "osc_27m",
> "clk_ext1", "clk_ext2",
> "clk_ext3", "clk_ext4";
> + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL2>,
> + <&clk IMX8MQ_CLK_AHB>,
> + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> + <&clk IMX8MQ_CLK_NOC>;
> + assigned-clock-parents = <0>,
> + <0>,
> + <0>,
> + <&clk IMX8MQ_SYS1_PLL_133M>,
> + <&clk IMX8MQ_SYS1_PLL_266M>,
> + <&clk IMX8MQ_SYS2_PLL_500M>,
> + <&clk IMX8MQ_CLK_27M>,
> + <&clk IMX8MQ_SYS1_PLL_800M>;
> + assigned-clock-rates = <593999999>,
> + <786432000>,
> + <722534400>;
> +
> +
> };
>
> src: reset-controller@30390000 {
togethe with http://code.bulix.org/pd88jp-812381?raw tested on
linux-20190725 (plus mipi dsi):
Tested-by: Guido Günther <agx@sigxcpu.org>
Cheers,
-- Guido
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
2019-07-29 8:31 ` Guido Günther
@ 2019-07-29 9:03 ` Daniel Baluta
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2019-07-29 9:03 UTC (permalink / raw)
To: Guido Günther
Cc: Daniel Baluta, Shawn Guo, Sascha Hauer, Fabio Estevam,
dl-linux-imx, Lucas Stach, Carlo Caione, Abel Vesa, baruch,
Andrey Smirnov, Devicetree List, linux-arm-kernel,
Linux Kernel Mailing List, S.j. Wang, Angus Ainslie (Purism),
Anson Huang
On Mon, Jul 29, 2019 at 11:32 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Hi,
> On Sun, Jul 28, 2019 at 05:12:18PM +0300, Daniel Baluta wrote:
> > From: Abel Vesa <abel.vesa@nxp.com>
> >
> > Add the initial configuration for clocks that need default parent and rate
> > setting. This is based on the vendor tree clock provider parents and rates
> > configuration except this is doing the setup in dts rather then using clock
> > consumer API in a clock provider driver.
> >
> > Note that by adding the initial rate setting for audio_pll1/audio_pll
> > setting we need to remove it from imx8mq-librem5-devkit.dts
> > imx8mq-librem5-devkit.dts
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> > Changes since v2:
> > - set rate for audio_pll1/audio_pll2 in the dtsi file and
> > remove the setting from imx8mq-librem5-devkit.dts
> >
> > .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> > 2 files changed, 21 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..c702ccc82867 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -169,11 +169,6 @@
> > };
> > };
> >
> > -&clk {
> > - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> > - assigned-clock-rates = <786432000>, <722534400>;
> > -};
> > -
> > &dphy {
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 02fbd0625318..c67625a881a4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -494,6 +494,27 @@
> > clock-names = "ckil", "osc_25m", "osc_27m",
> > "clk_ext1", "clk_ext2",
> > "clk_ext3", "clk_ext4";
> > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL2>,
> > + <&clk IMX8MQ_CLK_AHB>,
> > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> > + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> > + <&clk IMX8MQ_CLK_NOC>;
> > + assigned-clock-parents = <0>,
> > + <0>,
> > + <0>,
> > + <&clk IMX8MQ_SYS1_PLL_133M>,
> > + <&clk IMX8MQ_SYS1_PLL_266M>,
> > + <&clk IMX8MQ_SYS2_PLL_500M>,
> > + <&clk IMX8MQ_CLK_27M>,
> > + <&clk IMX8MQ_SYS1_PLL_800M>;
> > + assigned-clock-rates = <593999999>,
> > + <786432000>,
> > + <722534400>;
> > +
> > +
> > };
> >
> > src: reset-controller@30390000 {
>
> togethe with http://code.bulix.org/pd88jp-812381?raw tested on
> linux-20190725 (plus mipi dsi):
>
> Tested-by: Guido Günther <agx@sigxcpu.org>
Thanks for testing this Guido. Can you please add your Tested-by
to my fourth version of the patch.
[PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-29 9:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-28 14:12 [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks Daniel Baluta
2019-07-28 14:53 ` Angus Ainslie
2019-07-28 15:25 ` Daniel Baluta
2019-07-29 8:31 ` Guido Günther
2019-07-29 9:03 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).