From: Daniel Baluta <daniel.baluta@gmail.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: Shawn Guo <shawnguo@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
baruch@tkos.co.il, Anson Huang <anson.huang@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
ccaione@baylibre.com, Chris Spencer <spencercw@gmail.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Aisheng Dong <aisheng.dong@nxp.com>,
agx@sigxcpu.org, Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes
Date: Wed, 27 Mar 2019 11:51:45 +0200 [thread overview]
Message-ID: <CAEnQRZD27=jCvGB_Go-niXyEtrFu=MP2Wyvvqcx2CpnQ4Npx-Q@mail.gmail.com> (raw)
In-Reply-To: <f5934d5bca4b9241d0ac84de463fbeed@www.akkea.ca>
On Tue, Mar 26, 2019 at 11:44 PM Angus Ainslie <angus@akkea.ca> wrote:
>
> On 2019-03-19 07:31, Shawn Guo wrote:
> > On Fri, Mar 08, 2019 at 12:02:22PM +0000, Daniel Baluta wrote:
> >> SDMA1 is part of AIPS-3 region and SDMA2 is part
> >> of AIPS-1 region.
> >>
> >> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >
> > Reviewed-by tag should go after your SoB, since that's the sequence of
> > how they come.
> >
> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >> [initial submit in i.MX internal tree]
> >> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> >> [adaptation for linux-next]
> >
> > I would see these notes in commit log or even just cover letter.
> >
> > Shawn
> >
> >> ---
> >> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> >> 1 file changed, 22 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> >> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> >> index 9155bd4784eb..9d48450453fb 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> >> @@ -234,6 +234,17 @@
> >> status = "disabled";
> >> };
> >>
> >> + sdma2: sdma@302c0000 {
> >> + compatible = "fsl,imx8mq-sdma","fsl,imx7d-sdma";
> >> + reg = <0x302c0000 0x10000>;
> >> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>,
> >> + <&clk IMX8MQ_CLK_SDMA2_ROOT>;
> >> + clock-names = "ipg", "ahb";
> >> + #dma-cells = <3>;
> >> + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
> >> + };
> >> +
> >> iomuxc: iomuxc@30330000 {
> >> compatible = "fsl,imx8mq-iomuxc";
> >> reg = <0x30330000 0x10000>;
> >> @@ -575,6 +586,17 @@
> >> status = "disabled";
> >> };
> >>
> >> + sdma1: sdma@30bd0000 {
> >> + compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma";
>
> There shouldn't be a space in the imx8mq compatible string.
Oh, nice catch. This patch series is already in so care to send a fix?
Otherwise, I will take care of it.
thanks,
Daniel.
next prev parent reply other threads:[~2019-03-27 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 12:02 [PATCH v6 0/4] Enable wm8524 on i.MX8MQ-EVK Daniel Baluta
2019-03-08 12:02 ` [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes Daniel Baluta
2019-03-19 14:31 ` Shawn Guo
2019-03-26 21:44 ` Angus Ainslie
2019-03-27 9:51 ` Daniel Baluta [this message]
2019-03-27 13:25 ` Angus Ainslie
2019-03-08 12:02 ` [PATCH v6 2/4] bindings: fsl-imx-sdma: Document fsl,imx8mq-sdma compatbile string Daniel Baluta
2019-03-08 12:05 ` Fabio Estevam
2019-03-08 12:02 ` [PATCH v6 3/4] arm64: dts: imx8mq: Add SAI2 node Daniel Baluta
2019-03-08 12:06 ` Fabio Estevam
2019-03-08 12:02 ` [PATCH v6 4/4] arm64: dts: imx8mq-evk: Enable audio codec wm8952 Daniel Baluta
2019-03-08 12:06 ` Fabio Estevam
2019-03-19 14:41 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEnQRZD27=jCvGB_Go-niXyEtrFu=MP2Wyvvqcx2CpnQ4Npx-Q@mail.gmail.com' \
--to=daniel.baluta@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=aisheng.dong@nxp.com \
--cc=angus@akkea.ca \
--cc=anson.huang@nxp.com \
--cc=baruch@tkos.co.il \
--cc=ccaione@baylibre.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=spencercw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).