From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD440C072B1 for ; Tue, 28 May 2019 07:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A04120883 for ; Tue, 28 May 2019 07:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvV7ZF8u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727383AbfE1HK4 (ORCPT ); Tue, 28 May 2019 03:10:56 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44028 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfE1HK4 (ORCPT ); Tue, 28 May 2019 03:10:56 -0400 Received: by mail-ed1-f68.google.com with SMTP id w33so26812066edb.10; Tue, 28 May 2019 00:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sh90EuYxrh193Q7HMx34uXLBv/PVyFJE/lBow6rEA4k=; b=mvV7ZF8uWhYgBjffMM77I5Ql0OvSQtEllUykBqYO1LqPUptUBQ4Clj555ljFp5HxVB tBckbCbOVOLWEI507jR5cxLEYPcv/ryx77EQ82dXt2UJgPSyJ4DIYHQxIe2n5IfLP4F1 zwXLmW47ZFSuqV5IbKxsIGoUh95Y4ol8HmxTUegtt+E0uYC4T9yp8jWlpqgfLBY8hc6M W7mDI5P+EBlppPHhvwyAF71G1KPnEW8JSczuerHrAPmaGNxqSQPQVVs6tEN+O3J6nZMG MJ9hP6X7ANVuNFMa4njp86xSk5DWoatQd5Hi86TEx/W2JcB3nUMBy9qb+IIujHqVuZzg 26BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sh90EuYxrh193Q7HMx34uXLBv/PVyFJE/lBow6rEA4k=; b=ll9cupvjDuIrPArMzApTcZzpAYvXOA0z35fTNP6t8osXcP5CPPAwDqqgD89U7BFB7t aBTuyKPPPwB/ktOOgnge8BJT2FL2yftArrWq2KOuvwo0rk/r/n+rBo4ZJvAQ+cAT8Yyf vGelISF1Bvmri8yZ4rW8TIJXy6mvBNEqIpc60YlCbSG5HKSQOfuU/dBf0PGGzBIVewHq 6CAYUCvRtZXn/Puchl0qNbk4mrrFFPsLnnT6659hTPDsnGaUT4QzmM2bH5q3JRo3QTS9 LVwQmgfoIuiGXrmAO8mf/xVLH20mfJy2w5nkX17av8VTzjimz3z8HSKUoQPvtU4AS9Tm ETDA== X-Gm-Message-State: APjAAAUrZH2qkyLlDgGjlULpOP5CBL33eEQnlt1auDpErfqmKqN56Twa 4vYjTDc/EAB2XYqYisHnLedvOM5Uq8kZsnKPW+4= X-Google-Smtp-Source: APXvYqxNBlLhlVAOzGwcr+/jjrcH1xjzXnuJsY4nwozQ6IgG1ptIELlUIhMGBLO4K8gY4sqaP7ZTZpxsWKMvSqs+/sg= X-Received: by 2002:a50:ba5c:: with SMTP id 28mr48087986eds.238.1559027454465; Tue, 28 May 2019 00:10:54 -0700 (PDT) MIME-Version: 1.0 References: <20190515144210.25596-1-daniel.baluta@nxp.com> <20190515144210.25596-3-daniel.baluta@nxp.com> In-Reply-To: From: Daniel Baluta Date: Tue, 28 May 2019 10:10:43 +0300 Message-ID: Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 To: Fabio Estevam Cc: Daniel Baluta , "shawnguo@kernel.org" , "mark.rutland@arm.com" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , Anson Huang , "S.j. Wang" , Peng Fan , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "m.felsch@pengutronix.de" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > > + simple-audio-card,codec { > > > + sound-dai = <&wm8524>; > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > interface, not an external clock that feeds the codec. > > > > It seems you should remove this 'clocks' entry. > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > the representation is correct: > > Reviewed-by: Fabio Estevam Shawn, Can you have a look?