From: Daniel Baluta <daniel.baluta@gmail.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>
Subject: Re: [PATCH v3] firmware: imx: Add support to start/stop a CPU
Date: Mon, 4 Feb 2019 21:18:35 +0200 [thread overview]
Message-ID: <CAEnQRZDjN7z1nC8RSqaQXayz3rfBw6PGC69Knc4izGw62FnDGw@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB4211CBB9D46FC6EDB9DA9F1680910@AM0PR04MB4211.eurprd04.prod.outlook.com>
Hi Shawn,
Care to have a look?
Daniel.
On Thu, Jan 31, 2019 at 10:16 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>
> > -----Original Message-----
> > From: Daniel Baluta
> > Sent: Wednesday, January 30, 2019 9:30 PM
> > To: shawnguo@kernel.org
> > Cc: s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> > dl-linux-imx <linux-imx@nxp.com>; daniel.baluta@gmail.com; Aisheng Dong
> > <aisheng.dong@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; S.j. Wang <shengjiu.wang@nxp.com>; Daniel
> > Baluta <daniel.baluta@nxp.com>
> > Subject: [PATCH v3] firmware: imx: Add support to start/stop a CPU
> >
> > This is done via RPC call to SCU.
> >
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
>
> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
>
> Regards
> Dong Aisheng
>
> > ---
> > Changes since v2: (as per Aisheng's review)
> > - rename address with phys_address
> > - remove unnecessary uint8_t cast
> > - use 'true' as last parameter of imx_scu_call_rpc to actually
> > wait for a response from SCU.
> >
> > drivers/firmware/imx/misc.c | 38
> > +++++++++++++++++++++++++++
> > include/linux/firmware/imx/svc/misc.h | 3 +++
> > 2 files changed, 41 insertions(+)
> >
> > diff --git a/drivers/firmware/imx/misc.c b/drivers/firmware/imx/misc.c index
> > 97f5424dbac9..4b56a587dacd 100644
> > --- a/drivers/firmware/imx/misc.c
> > +++ b/drivers/firmware/imx/misc.c
> > @@ -18,6 +18,14 @@ struct imx_sc_msg_req_misc_set_ctrl {
> > u16 resource;
> > } __packed;
> >
> > +struct imx_sc_msg_req_cpu_start {
> > + struct imx_sc_rpc_msg hdr;
> > + u32 address_hi;
> > + u32 address_lo;
> > + u16 resource;
> > + u8 enable;
> > +} __packed;
> > +
> > struct imx_sc_msg_req_misc_get_ctrl {
> > struct imx_sc_rpc_msg hdr;
> > u32 ctrl;
> > @@ -97,3 +105,33 @@ int imx_sc_misc_get_control(struct imx_sc_ipc *ipc,
> > u32 resource,
> > return 0;
> > }
> > EXPORT_SYMBOL(imx_sc_misc_get_control);
> > +
> > +/*
> > + * This function starts/stops a CPU identified by @resource
> > + *
> > + * @param[in] ipc IPC handle
> > + * @param[in] resource resource the control is associated with
> > + * @param[in] enable true for start, false for stop
> > + * @param[in] phys_addr initial instruction address to be executed
> > + *
> > + * @return Returns 0 for success and < 0 for errors.
> > + */
> > +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> > + bool enable, u64 phys_addr)
> > +{
> > + struct imx_sc_msg_req_cpu_start msg;
> > + struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > +
> > + hdr->ver = IMX_SC_RPC_VERSION;
> > + hdr->svc = IMX_SC_RPC_SVC_PM;
> > + hdr->func = IMX_SC_PM_FUNC_CPU_START;
> > + hdr->size = 4;
> > +
> > + msg.address_hi = phys_addr >> 32;
> > + msg.address_lo = phys_addr;
> > + msg.resource = resource;
> > + msg.enable = enable;
> > +
> > + return imx_scu_call_rpc(ipc, &msg, true); }
> > +EXPORT_SYMBOL(imx_sc_pm_cpu_start);
> > diff --git a/include/linux/firmware/imx/svc/misc.h
> > b/include/linux/firmware/imx/svc/misc.h
> > index e21c49aba92f..031dd4d3c766 100644
> > --- a/include/linux/firmware/imx/svc/misc.h
> > +++ b/include/linux/firmware/imx/svc/misc.h
> > @@ -52,4 +52,7 @@ int imx_sc_misc_set_control(struct imx_sc_ipc *ipc, u32
> > resource, int imx_sc_misc_get_control(struct imx_sc_ipc *ipc, u32 resource,
> > u8 ctrl, u32 *val);
> >
> > +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> > + bool enable, u64 phys_addr);
> > +
> > #endif /* _SC_MISC_API_H */
> > --
> > 2.17.1
>
next prev parent reply other threads:[~2019-02-04 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 13:30 [PATCH v3] firmware: imx: Add support to start/stop a CPU Daniel Baluta
2019-01-31 8:16 ` Aisheng Dong
2019-02-04 19:18 ` Daniel Baluta [this message]
2019-02-11 2:01 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZDjN7z1nC8RSqaQXayz3rfBw6PGC69Knc4izGw62FnDGw@mail.gmail.com \
--to=daniel.baluta@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).