From: Bjorn Helgaas <bhelgaas@google.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Kit Chow <kchow@gigaio.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 1/2] PCI: Prevent 64-bit resources from being counted in 32-bit bridge region
Date: Mon, 4 Mar 2019 14:11:57 -0600 [thread overview]
Message-ID: <CAErSpo4U6Kys5OzPwfyFdbnJWfTZ-y0P830okf11BwfNv9Y82A@mail.gmail.com> (raw)
In-Reply-To: <3e45b4ab-e848-cf3b-624f-121ad58b0250@deltatee.com>
On Mon, Mar 4, 2019 at 1:21 PM Logan Gunthorpe <logang@deltatee.com> wrote:
> On 2019-03-03 5:23 p.m., Bjorn Helgaas wrote:
> > Sorry for the delay. This code gives a headache. I still remember
> > my headache from the last time we touched it. Help me understand
> > what's going on here.
>
> Yes, this code gave me a headache debugging it too. And it's not the
> first time I've tried to figure out what's going on with it because it
> often just prints noisy messages that look like errors. I think I
> understand it better now but it's something that's a bit fleeting and
> easy to forget the details of. There may also be other solutions to this
> problem.
Thanks for the explanation below. I haven't worked through it yet, but I will.
Obviously it would be far better than an explanation if we could
simplify the code (and the noisy messages) such that it didn't
*require* so much explanation.
Bjorn
next prev parent reply other threads:[~2019-03-04 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 17:00 [PATCH 1/2] PCI: Prevent 64-bit resources from being counted in 32-bit bridge region Logan Gunthorpe
2019-02-14 17:00 ` [PATCH 2/2] PCI: Fix disabling of bridge BARs when assigning bus resources Logan Gunthorpe
2019-03-04 0:23 ` [PATCH 1/2] PCI: Prevent 64-bit resources from being counted in 32-bit bridge region Bjorn Helgaas
2019-03-04 19:21 ` Logan Gunthorpe
2019-03-04 20:11 ` Bjorn Helgaas [this message]
2019-03-04 20:21 ` Logan Gunthorpe
2019-03-04 20:29 ` Bjorn Helgaas
2019-03-04 20:39 ` Logan Gunthorpe
2019-04-01 19:22 ` Logan Gunthorpe
2019-03-04 23:58 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo4U6Kys5OzPwfyFdbnJWfTZ-y0P830okf11BwfNv9Y82A@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kchow@gigaio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).