From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbcFUBct (ORCPT ); Mon, 20 Jun 2016 21:32:49 -0400 Received: from mail-yw0-f175.google.com ([209.85.161.175]:33304 "EHLO mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932273AbcFUBcd (ORCPT ); Mon, 20 Jun 2016 21:32:33 -0400 MIME-Version: 1.0 In-Reply-To: <20160621110838.4d4f1171@canb.auug.org.au> References: <20160620115213.07231836@canb.auug.org.au> <20160620191136.GA17036@localhost> <20160621110838.4d4f1171@canb.auug.org.au> From: Bjorn Helgaas Date: Mon, 20 Jun 2016 20:27:03 -0500 Message-ID: Subject: Re: linux-next: build warnings after merge of the pci tree To: Stephen Rothwell Cc: Bjorn Helgaas , linux-next list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2016 at 8:08 PM, Stephen Rothwell wrote: > Hi Bjorn, > > On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas wrote: >> >> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote: >> > Hi Bjorn, >> > >> > After merging the pci tree, today's linux-next build (arm >> > multi_v7_defconfig) produced these warnings: >> > >> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init': >> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion] >> > return err; >> > ^ >> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion] >> > return PTR_ERR(cfg); >> > ^ >> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion] >> > return err; >> > ^ >> > >> > Introduced by commit >> > >> > 3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated") >> >> Fixed, thanks a lot, Stephen! > > Thanks. Unfortunately, I still get this warning: > > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init': > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion] > return PTR_ERR(cfg); > ^ Crap, sorry, PTR_ERR/ERR_PTR confusion. I *think* I fixed it now. Bjorn