From: Bjorn Helgaas <bhelgaas@google.com>
To: Boris Ostrovsky <boris.ostrovsky@amd.com>
Cc: herrmann.der.user@googlemail.com, khali@linux-fr.org,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86,AMD: Power driver support for AMD's family 16h processors
Date: Tue, 4 Dec 2012 10:26:16 -0700 [thread overview]
Message-ID: <CAErSpo4p1-=71SXN3eg0KVu_S0mwjVjYUBfXSBMypJAatvnAiA@mail.gmail.com> (raw)
In-Reply-To: <1354623004-8169-1-git-send-email-boris.ostrovsky@amd.com>
On Tue, Dec 4, 2012 at 5:10 AM, Boris Ostrovsky <boris.ostrovsky@amd.com> wrote:
> Add family 16h PCI ID to AMD's power driver to allow it report
> power consumption on these processors.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com>
> ---
> drivers/hwmon/fam15h_power.c | 1 +
> include/linux/pci_ids.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
> index 4f41104..dda1113 100644
> --- a/drivers/hwmon/fam15h_power.c
> +++ b/drivers/hwmon/fam15h_power.c
> @@ -248,6 +248,7 @@ static void __devexit fam15h_power_remove(struct pci_dev *pdev)
>
> static DEFINE_PCI_DEVICE_TABLE(fam15h_power_id_table) = {
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F4) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F4) },
> {}
> };
> MODULE_DEVICE_TABLE(pci, fam15h_power_id_table);
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 9d36b82..9c9a464 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -524,6 +524,7 @@
> #define PCI_DEVICE_ID_AMD_15H_NB_F3 0x1603
> #define PCI_DEVICE_ID_AMD_15H_NB_F4 0x1604
> #define PCI_DEVICE_ID_AMD_15H_NB_F5 0x1605
> +#define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534
> #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
> #define PCI_DEVICE_ID_AMD_LANCE 0x2000
> #define PCI_DEVICE_ID_AMD_LANCE_HOME 0x2001
Read the comment at the top of pci_ids.h. Based on just this patch,
it doesn't seem like the pci_ids.h change is warranted.
Bjorn
next prev parent reply other threads:[~2012-12-04 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 12:10 [PATCH] x86,AMD: Power driver support for AMD's family 16h processors Boris Ostrovsky
2012-12-04 17:26 ` Bjorn Helgaas [this message]
2012-12-05 5:09 ` [lm-sensors] [PATCH] x86, AMD: " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAErSpo4p1-=71SXN3eg0KVu_S0mwjVjYUBfXSBMypJAatvnAiA@mail.gmail.com' \
--to=bhelgaas@google.com \
--cc=boris.ostrovsky@amd.com \
--cc=herrmann.der.user@googlemail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).