From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093Ab2KIPLi (ORCPT ); Fri, 9 Nov 2012 10:11:38 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:45013 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527Ab2KIPLg (ORCPT ); Fri, 9 Nov 2012 10:11:36 -0500 MIME-Version: 1.0 In-Reply-To: <20121108200445.GC16012@intel.com> References: <1351928793-14375-1-git-send-email-mika.westerberg@linux.intel.com> <3455360.Z6cZSC3BtR@vostro.rjw.lan> <1523215.Pon1eKPQDb@vostro.rjw.lan> <20121107095608.GX24532@intel.com> <20121108200445.GC16012@intel.com> From: Bjorn Helgaas Date: Fri, 9 Nov 2012 08:11:13 -0700 Message-ID: Subject: Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support To: Mika Westerberg Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de, mathias.nyman@linux.intel.com, linux-acpi@vger.kernel.org, Greg Kroah-Hartman , "H. Peter Anvin" , Tony Luck Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Greg, Peter, Tony since they acked the original patch [1]] On Thu, Nov 8, 2012 at 1:04 PM, Mika Westerberg wrote: > On Thu, Nov 08, 2012 at 12:32:25PM -0700, Bjorn Helgaas wrote: >> Struct device_driver is a generic structure, so it seems strange to >> have to include non-generic things like of_device_id and now >> acpi_match_table there. > > Yes, but in a sense the DT and ACPI are "generic". So that they are used to > describe the configuration of a machine. What I meant by "generic" was "useful across all architectures." The new acpi_match_table and acpi_handle fields [1] are not generic in that sense because they're present on all architectures but used only on x86 and ia64. The existing of_match_table and of_node are similarly unused on many architectures. This doesn't seem like a scalable strategy to me. Are we going to add a pnpbios_node for x86 PNPBIOS machines without ACPI, a pdc_hpa for parisc machines with PDC, etc.? [1] https://patchwork.kernel.org/patch/1677221/