From: Bjorn Helgaas <bhelgaas@google.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg()
Date: Thu, 31 Jan 2013 10:13:17 -0700 [thread overview]
Message-ID: <CAErSpo7grYijCUZGWGM4jao+MUqXYQ66q1az6bbKPMX4_Jwcyg@mail.gmail.com> (raw)
In-Reply-To: <1359367251.883.13.camel@x61.thuisdomein>
[+cc Rafael]
On Mon, Jan 28, 2013 at 3:00 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> In each suspend and resume cycle my laptop prints these messages at
> KERN_INFO level:
> pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
> pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
>
> and
> pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
> pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
>
> Messages like these are probably only useful while debugging pciehp, so
> let's hide them behind the ctrl_dbg() macro.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Compile tested only!
>
> 1) Perhaps a better solution is to drop these messages entirely.
>
> drivers/pci/hotplug/pciehp_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
> index 939bd1d..ed1702d 100644
> --- a/drivers/pci/hotplug/pciehp_core.c
> +++ b/drivers/pci/hotplug/pciehp_core.c
> @@ -293,7 +293,8 @@ static void pciehp_remove(struct pcie_device *dev)
> #ifdef CONFIG_PM
> static int pciehp_suspend (struct pcie_device *dev)
> {
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> + struct controller *ctrl = get_service_data(dev);
> + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> return 0;
I'd propose to just drop these messages completely. Rafael, would you
have any objection to that?
> }
>
> @@ -303,8 +304,8 @@ static int pciehp_resume (struct pcie_device *dev)
> struct slot *slot;
> u8 status;
>
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> ctrl = get_service_data(dev);
> + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
>
> /* reinitialize the chipset's event detection logic */
> pcie_enable_notification(ctrl);
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2013-01-31 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 10:00 [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg() Paul Bolle
2013-01-31 17:13 ` Bjorn Helgaas [this message]
2013-01-31 17:54 ` Rafael J. Wysocki
2013-01-31 18:35 ` [PATCH v2] PCI: pciehp: drop ENTRY messages Paul Bolle
2013-02-01 22:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7grYijCUZGWGM4jao+MUqXYQ66q1az6bbKPMX4_Jwcyg@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).