From: Bongsu Jeon <bs.jeon87@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Bongsu Jeon <bongsu.jeon@samsung.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net/nfc/nci: Support NCI 2.x initial sequence
Date: Wed, 18 Nov 2020 13:29:09 +0900 [thread overview]
Message-ID: <CAEx-X7cjKNAYzpifOX=qaqpNVSuGEE6t69R=Zf=DZjFrp9PZ4w@mail.gmail.com> (raw)
In-Reply-To: <20201117175758.3befce93@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 11/18/20, Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 17 Nov 2020 14:37:59 +0900 Bongsu Jeon wrote:
>> implement the NCI 2.x initial sequence to support NCI 2.x NFCC.
>> Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed.
>> If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work.
>>
>> In NCI 1.0, Initial sequence and payloads are as below:
>> (DH) (NFCC)
>> | -- CORE_RESET_CMD --> |
>> | <-- CORE_RESET_RSP -- |
>> | -- CORE_INIT_CMD --> |
>> | <-- CORE_INIT_RSP -- |
>> CORE_RESET_RSP payloads are Status, NCI version, Configuration Status.
>> CORE_INIT_CMD payloads are empty.
>> CORE_INIT_RSP payloads are Status, NFCC Features,
>> Number of Supported RF Interfaces, Supported RF Interface,
>> Max Logical Connections, Max Routing table Size,
>> Max Control Packet Payload Size, Max Size for Large Parameters,
>> Manufacturer ID, Manufacturer Specific Information.
>>
>> In NCI 2.0, Initial Sequence and Parameters are as below:
>> (DH) (NFCC)
>> | -- CORE_RESET_CMD --> |
>> | <-- CORE_RESET_RSP -- |
>> | <-- CORE_RESET_NTF -- |
>> | -- CORE_INIT_CMD --> |
>> | <-- CORE_INIT_RSP -- |
>> CORE_RESET_RSP payloads are Status.
>> CORE_RESET_NTF payloads are Reset Trigger,
>> Configuration Status, NCI Version, Manufacturer ID,
>> Manufacturer Specific Information Length,
>> Manufacturer Specific Information.
>> CORE_INIT_CMD payloads are Feature1, Feature2.
>> CORE_INIT_RSP payloads are Status, NFCC Features,
>> Max Logical Connections, Max Routing Table Size,
>> Max Control Packet Payload Size,
>> Max Data Packet Payload Size of the Static HCI Connection,
>> Number of Credits of the Static HCI Connection,
>> Max NFC-V RF Frame Size, Number of Supported RF Interfaces,
>> Supported RF Interfaces.
>>
>> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> Please fix the following sparse (build with C=1) warning:
>
> net/nfc/nci/ntf.c:42:17: warning: cast to restricted __le32
>
>> + __u8 status = 0;
>
> Please don't use the __u types in the normal kernel code, those are
> types for user space ABI.
>
Thanks for reviewing my patch.
I will change the code to fix it
and then resend my patch with version2.
prev parent reply other threads:[~2020-11-18 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201117053759epcms2p80e47c3e9be01d564c775c045a42678f7@epcms2p8>
2020-11-17 5:37 ` [PATCH net-next] net/nfc/nci: Support NCI 2.x initial sequence Bongsu Jeon
2020-11-18 1:57 ` Jakub Kicinski
2020-11-18 4:29 ` Bongsu Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEx-X7cjKNAYzpifOX=qaqpNVSuGEE6t69R=Zf=DZjFrp9PZ4w@mail.gmail.com' \
--to=bs.jeon87@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).