From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757837Ab2IGFsw (ORCPT ); Fri, 7 Sep 2012 01:48:52 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:50192 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530Ab2IGFsu (ORCPT ); Fri, 7 Sep 2012 01:48:50 -0400 MIME-Version: 1.0 Reply-To: axel.lin@gmail.com In-Reply-To: <5049346B.5020205@gmail.com> References: <1346675368.15950.0.camel@phoenix> <5049346B.5020205@gmail.com> From: Axel Lin Date: Fri, 7 Sep 2012 13:48:30 +0800 Message-ID: Subject: Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared To: Ryan Mallon Cc: Hartley Sweeten , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Axel, > > The patch looks fine. I notice that the other ep93xx boards are also > using the SZ_ defines, but are indirectly including linux/sizes.h via > asm/memory.h, which in turn is indirectly included via asm/io.h. That Seems this is also true for other platforms ( e.g. mach-pxa, mach-ux500, etc) > seems a bit flaky, so I wonder if we should just explicitly include > in all the board files which use the SZ_ macros as per > the patch below. Thoughts? I'm 50/50 on this. But if we do these changes, this patch is more than a build fix. Regards, Axel