linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: Add empty devm_regulator_free for !CONFIG_REGULATOR
Date: Sun, 29 Jan 2012 17:42:51 +0800	[thread overview]
Message-ID: <CAF+7xWn2AkcEyOb5FmXNbGA7U2=n83kvAz+=GGLMh+8yNm8UKw@mail.gmail.com> (raw)
In-Reply-To: <1327804218.16295.1.camel@phoenix>

> +static inline void devm_regulator_free(struct regulator *regulator)
> +{
> +}
> +

Oh wait.
I found commit d5ad34f7cb "regulator: Implement devm_regulator_free()"
has declared devm_regulator_free in include/linux/regulator/consumer.h
But it actually implements devm_regulator_put instead of devm_regulator_free.

Mark, I guess what you want is to declare devm_regulator_put instead
of devm_regulator_free
in consumer.h.

Regards,
Axel
>  static inline int regulator_enable(struct regulator *regulator)
>  {
>        return 0;
> --
> 1.7.5.4
>
>
>

  reply	other threads:[~2012-01-29  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29  2:30 [PATCH] regulator: Add empty devm_regulator_free for !CONFIG_REGULATOR Axel Lin
2012-01-29  9:42 ` Axel Lin [this message]
2012-01-29 21:28   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF+7xWn2AkcEyOb5FmXNbGA7U2=n83kvAz+=GGLMh+8yNm8UKw@mail.gmail.com' \
    --to=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).