From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932782AbcFIVyY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 17:54:24 -0400
Received: from mail.kernel.org ([198.145.29.136]:55224 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932160AbcFIVyV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 17:54:21 -0400
MIME-Version: 1.0
In-Reply-To: <051801d1c297$c7d8a7d0$5789f770$@opengridcomputing.com>
References: <1465248215-18186-1-git-send-email-hch@lst.de> <1465248215-18186-5-git-send-email-hch@lst.de>
 <5756B75C.9000409@lightbits.io> <051801d1c297$c7d8a7d0$5789f770$@opengridcomputing.com>
From: Ming Lin <mlin@kernel.org>
Date: Thu, 9 Jun 2016 14:54:16 -0700
X-Gmail-Original-Message-ID: <CAF1ivSag+pbhRcNu+VmJYd5FmzwxZ==Ebge78TaZkXqKC-Sidg@mail.gmail.com>
Message-ID: <CAF1ivSag+pbhRcNu+VmJYd5FmzwxZ==Ebge78TaZkXqKC-Sidg@mail.gmail.com>
Subject: Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver
To: Steve Wise <swise@opengridcomputing.com>
Cc: Sagi Grimberg <sagi@lightbits.io>, Christoph Hellwig <hch@lst.de>,
        Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
        linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>,
        Armen Baloyan <armenx.baloyan@intel.com>,
        Jay Freyensee <james.p.freyensee@intel.com>,
        Ming Lin <ming.l@ssi.samsung.com>, linux-rdma@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 9, 2016 at 2:42 PM, Steve Wise <swise@opengridcomputing.com> wrote:

> Should the above error path actually goto a block that frees the rsps?  Like
> this?
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index c184ee5..8aaa36f 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1053,7 +1053,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
>                                 !queue->host_qid);
>                 if (IS_ERR(queue->cmds)) {
>                         ret = NVME_RDMA_CM_NO_RSC;
> -                       goto out_free_cmds;
> +                       goto out_free_responses;
>                 }
>         }
>
> @@ -1073,6 +1073,8 @@ out_free_cmds:
>                                 queue->recv_queue_size,
>                                 !queue->host_qid);
>         }
> +out_free_responses:
> +        nvmet_rdma_free_rsps(queue);
>  out_ida_remove:
>         ida_simple_remove(&nvmet_rdma_queue_ida, queue->idx);
>  out_destroy_sq:

Yes. Nice catch.