From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756Ab2DKEto (ORCPT ); Wed, 11 Apr 2012 00:49:44 -0400 Received: from [124.207.24.138] ([124.207.24.138]:42470 "EHLO mail.ss.pku.edu.cn" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750871Ab2DKEtn convert rfc822-to-8bit (ORCPT ); Wed, 11 Apr 2012 00:49:43 -0400 MIME-Version: 1.0 In-Reply-To: <1332956242-5352-3-git-send-email-konrad.wilk@oracle.com> References: <20120328092358.GD22885@gmail.com> <1332956242-5352-1-git-send-email-konrad.wilk@oracle.com> <1332956242-5352-3-git-send-email-konrad.wilk@oracle.com> Date: Wed, 11 Apr 2012 12:49:02 +0800 Message-ID: Subject: Re: [PATCH 2/2] xen/x86: Implement x86_apic_ops From: Lin Ming To: Konrad Rzeszutek Wilk Cc: mingo@elte.hu, suresh.b.siddha@intel.com, jwboyer@redhat.com, hpa@zytor.com, yinghai@kernel.org, linux-kernel@vger.kernel.org, xiantao.zhang@intel.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 29, 2012 at 1:37 AM, Konrad Rzeszutek Wilk wrote: > Or rather just implement one different function as opposed > to the native one : the read function. > > We synthesize the values. > > Acked-by:  Suresh Siddha > [v1: Rebased on top of tip/x86/urgent] > Signed-off-by: Konrad Rzeszutek Wilk > --- >  arch/x86/xen/Makefile    |    2 +- >  arch/x86/xen/apic.c      |   17 +++++++++++++++++ >  arch/x86/xen/enlighten.c |    2 ++ >  arch/x86/xen/xen-ops.h   |    4 ++++ >  4 files changed, 24 insertions(+), 1 deletions(-) >  create mode 100644 arch/x86/xen/apic.c > > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index add2c2d..96ab2c0 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -20,5 +20,5 @@ obj-$(CONFIG_EVENT_TRACING) += trace.o >  obj-$(CONFIG_SMP)              += smp.o >  obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o >  obj-$(CONFIG_XEN_DEBUG_FS)     += debugfs.o > -obj-$(CONFIG_XEN_DOM0)         += vga.o > +obj-$(CONFIG_XEN_DOM0)         += apic.o vga.o >  obj-$(CONFIG_SWIOTLB_XEN)      += pci-swiotlb-xen.o > diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c > new file mode 100644 > index 0000000..aee16ab > --- /dev/null > +++ b/arch/x86/xen/apic.c > @@ -0,0 +1,17 @@ > +#include > +#include > + > +unsigned int xen_io_apic_read(unsigned apic, unsigned reg) > +{ > +       if (reg == 0x1) > +               return 0x00170020; > +       else if (reg == 0x0) > +               return apic << 24; Why is fixed value returned? Can't we implement it with hypercall(PHYSDEVOP_apic_read)? Lin Ming > + > +       return 0xff; > +} > + > +void __init xen_init_apic(void) > +{ > +       x86_io_apic_ops.read = xen_io_apic_read; > +} > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index 4172af8..a7df080 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1271,6 +1271,8 @@ asmlinkage void __init xen_start_kernel(void) >                xen_start_info->console.domU.mfn = 0; >                xen_start_info->console.domU.evtchn = 0; > > +               xen_init_apic(); > + >                /* Make sure ACS will be enabled */ >                pci_request_acs(); >        } > diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h > index b095739..45c0c06 100644 > --- a/arch/x86/xen/xen-ops.h > +++ b/arch/x86/xen/xen-ops.h > @@ -92,11 +92,15 @@ struct dom0_vga_console_info; > >  #ifdef CONFIG_XEN_DOM0 >  void __init xen_init_vga(const struct dom0_vga_console_info *, size_t size); > +void __init xen_init_apic(void); >  #else >  static inline void __init xen_init_vga(const struct dom0_vga_console_info *info, >                                       size_t size) >  { >  } > +static inline void __init xen_init_apic(void) > +{ > +} >  #endif > >  /* Declare an asm function, along with symbols needed to make it > -- > 1.7.7.5