From: Ming Lin <mlin@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lin <mlin@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Jens Axboe <axboe@kernel.dk>, Dongsu Park <dpark@posteo.net>
Subject: Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs
Date: Sun, 24 May 2015 00:37:32 -0700 [thread overview]
Message-ID: <CAF1ivSbfDwoEWzWFjopXtegXUhfQB4PbApHiM94oBa6cw1JKqA@mail.gmail.com> (raw)
In-Reply-To: <20150523141522.GA19470@lst.de>
On Sat, May 23, 2015 at 7:15 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote:
>> This will bring not only performance improvements, but also a great amount
>> of reduction in code complexity all over the block layer. Performance gain
>> is possible due to the fact that bio_add_page() does not have to check
>> unnecesary conditions such as queue limits or if biovecs are mergeable.
>> Those will be delegated to the driver level. Kent already said that he
>> actually benchmarked the impact of this with fio on a micron p320h, which
>> showed definitely a positive impact.
>
> We'll need some actual numbers. I actually like these changes a lot
> and don't even need a performance justification for this fundamentally
> better model, but I'd really prefer to avoid any large scale regressions.
> I don't really expect them, but for code this fundamental we'll just
> need some benchmarks.
>
> Except for that these changes looks good, and the previous version
> passed my tests fine, so with some benchmarks you'ĺl have my ACK.
I'll test it on a 2 sockets server with 10 NVMe drives on Monday.
I'm going to run fio tests:
1. raw NVMe drives direct IO read/write
2. ext4 read/write
Let me know if you have other tests that I can run.
Thanks.
>
> I'd love to see this go into 4.2, but for that we'll need Jens
> approval and a merge into for-next very soon.
next prev parent reply other threads:[~2015-05-24 7:37 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 18:18 [PATCH v4 00/11] simplify block layer based on immutable biovecs Ming Lin
2015-05-22 18:18 ` [PATCH v4 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-25 5:46 ` NeilBrown
2015-05-26 14:36 ` Mike Snitzer
2015-05-26 15:02 ` Ming Lin
2015-05-26 15:34 ` Alasdair G Kergon
2015-05-26 23:06 ` NeilBrown
2015-05-27 0:40 ` [dm-devel] " Alasdair G Kergon
2015-05-27 8:20 ` Christoph Hellwig
2015-05-26 16:04 ` Mike Snitzer
2015-05-26 17:17 ` Ming Lin
2015-05-27 23:42 ` Ming Lin
2015-05-28 0:36 ` Alasdair G Kergon
2015-05-28 5:54 ` Ming Lin
2015-05-29 7:05 ` Ming Lin
2015-05-29 15:15 ` Mike Snitzer
2015-06-01 6:02 ` Ming Lin
2015-06-02 20:59 ` Ming Lin
2015-06-04 21:06 ` Mike Snitzer
2015-06-04 22:21 ` Ming Lin
2015-06-05 0:06 ` Mike Snitzer
2015-06-05 5:21 ` Ming Lin
2015-06-09 6:09 ` Ming Lin
2015-06-10 21:20 ` Ming Lin
2015-06-10 21:46 ` Mike Snitzer
2015-06-10 22:06 ` Ming Lin
2015-06-12 5:49 ` Ming Lin
2015-06-18 5:27 ` Ming Lin
2015-05-22 18:18 ` [PATCH v4 02/11] block: simplify bio_add_page() Ming Lin
2015-05-22 18:18 ` [PATCH v4 03/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-22 18:18 ` [PATCH v4 04/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-22 18:18 ` [PATCH v4 05/11] block: remove split code in blkdev_issue_discard Ming Lin
2015-05-22 18:18 ` [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-25 5:48 ` NeilBrown
2015-05-25 7:03 ` Ming Lin
2015-05-25 7:54 ` NeilBrown
2015-05-25 14:17 ` Christoph Hellwig
2015-05-26 14:33 ` Ming Lin
2015-05-26 22:32 ` Ming Lin
2015-05-26 23:03 ` NeilBrown
2015-05-26 23:42 ` Ming Lin
2015-05-27 0:38 ` NeilBrown
2015-05-27 8:15 ` Christoph Hellwig
2015-05-22 18:18 ` [PATCH v4 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-22 18:18 ` [PATCH v4 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-25 5:49 ` NeilBrown
2015-05-25 14:04 ` Christoph Hellwig
2015-05-25 15:02 ` Ilya Dryomov
2015-05-25 15:08 ` Christoph Hellwig
2015-05-25 15:19 ` Ilya Dryomov
2015-05-25 15:35 ` Alex Elder
2015-05-22 18:18 ` [PATCH v4 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-22 18:18 ` [PATCH v4 10/11] block: remove bio_get_nr_vecs() Ming Lin
2015-05-22 18:18 ` [PATCH v4 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-05-23 14:15 ` [PATCH v4 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-24 7:37 ` Ming Lin [this message]
2015-05-25 13:51 ` Christoph Hellwig
2015-05-29 6:39 ` Ming Lin
2015-06-01 6:15 ` Ming Lin
2015-06-03 6:57 ` Christoph Hellwig
2015-06-03 13:28 ` Jeff Moyer
2015-06-03 17:06 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF1ivSbfDwoEWzWFjopXtegXUhfQB4PbApHiM94oBa6cw1JKqA@mail.gmail.com \
--to=mlin@kernel.org \
--cc=axboe@kernel.dk \
--cc=dpark@posteo.net \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).