From: Rob Clark <rob.clark@linaro.org>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>,
sumit.semwal@linaro.org, rob.clark@linaro.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [Linaro-mm-sig] [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER
Date: Sat, 11 Aug 2012 10:17:02 -0500 [thread overview]
Message-ID: <CAF6AEGs8AzrQBhw523kFrJp-C_y3-TdL7HWy5FfYVUO2U-poOA@mail.gmail.com> (raw)
In-Reply-To: <20120810193210.GG5738@phenom.ffwll.local>
On Fri, Aug 10, 2012 at 2:32 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Aug 10, 2012 at 04:57:43PM +0200, Maarten Lankhorst wrote:
>> Documentation says that code requiring dma-buf should add it to
>> select, so inline fallbacks are not going to be used. A link error
>> will make it obvious what went wrong, instead of silently doing
>> nothing at runtime.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
>
> I've botched it more than once to update these when creating new dma-buf
> code. Hence
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
yeah, I think the fallbacks date back to when it was a user
configurable option, rather than something select'd by drivers using
dmabuf, and we just never went back to clean up. Let's drop the
fallbacks.
Reviewed-by: Rob Clark <rob.clark@linaro.org>
> --
> Daniel Vetter
> Mail: daniel@ffwll.ch
> Mobile: +41 (0)79 365 57 48
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-08-11 15:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 14:57 [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER Maarten Lankhorst
2012-08-10 14:57 ` [PATCH 2/4] dma-fence: dma-buf synchronization (v8 ) Maarten Lankhorst
2012-08-10 20:29 ` [Linaro-mm-sig] " Daniel Vetter
2012-08-11 15:14 ` Rob Clark
2012-08-11 16:00 ` Maarten Lankhorst
2012-08-11 19:39 ` Daniel Vetter
2012-08-13 12:43 ` Maarten Lankhorst
2012-08-11 19:22 ` Daniel Vetter
2012-08-11 20:50 ` Rob Clark
2012-08-12 9:34 ` Daniel Vetter
2012-08-29 17:49 ` Francesco Lavra
2012-08-10 14:57 ` [PATCH 3/4] dma-seqno-fence: Hardware dma-buf implementation of fencing (v2) Maarten Lankhorst
2012-08-10 19:57 ` [Linaro-mm-sig] " Daniel Vetter
2012-08-11 16:05 ` Maarten Lankhorst
2012-08-10 14:58 ` [PATCH 4/4] dma-buf-mgr: multiple dma-buf synchronization (v3) Maarten Lankhorst
2012-08-15 23:12 ` [Linaro-mm-sig] " Daniel Vetter
2012-08-22 11:50 ` [RFC patch 4/4] " Maarten Lankhorst
2012-08-22 12:52 ` Thomas Hellstrom
2012-08-22 13:32 ` Maarten Lankhorst
2012-08-22 14:12 ` Thomas Hellstrom
2012-08-22 15:13 ` Daniel Vetter
2012-08-10 19:32 ` [Linaro-mm-sig] [PATCH 1/4] dma-buf: remove fallback for !CONFIG_DMA_SHARED_BUFFER Daniel Vetter
2012-08-11 15:17 ` Rob Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF6AEGs8AzrQBhw523kFrJp-C_y3-TdL7HWy5FfYVUO2U-poOA@mail.gmail.com \
--to=rob.clark@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).