From: Rob Clark <robdclark@gmail.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: Daniel Vetter <daniel@ffwll.ch>,
hch@lst.de, David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sean Paul <seanpaul@chromium.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*
Date: Thu, 29 Nov 2018 13:57:38 -0500 [thread overview]
Message-ID: <CAF6AEGsT9RO2RmgBTa0HQRjRUiRKy9N3vQxvD7RVWp4HpnWn+w@mail.gmail.com> (raw)
In-Reply-To: <CAAFQd5A-Bh711VaNWhRJqcrofkBVCMFcNgqfztoyWJcUdhSu0Q@mail.gmail.com>
On Thu, Nov 29, 2018 at 12:24 PM Tomasz Figa <tfiga@chromium.org> wrote:
>
> [CC Marek]
>
> On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Note that one thing I'd like to avoid is exposing these funtions directly
> > > to drivers, as that will get us into all kinds of abuses.
> >
> > What kind of abuse do you expect? It could very well be that gpu folks
> > call that "standard use case" ... At least on x86 with the i915 driver
> > we pretty much rely on architectural guarantees for how cache flushes
> > work very much. Down to userspace doing the cache flushing for
> > mappings the kernel has set up.
>
> i915 is a very specific case of a fully contained,
> architecture-specific hardware subsystem, where you can just hardcode
> all integration details inside the driver, because nobody else would
> care.
>
> In ARM world, you can have the same IP blocks licensed by multiple SoC
> vendors with different integration details and that often includes the
> option of coherency.
fwiw, I believe all the GPU IP blocks that are used across multiple
SoCs have their own GPU MMU (potentially in addition to an iommu?).
So the dma-api is a much better fit for them.. drm/msm is a lot
closer to drm/i915 scenario, so I don't so much care if the solution
to our unique problem isn't something that would work for other
drivers ;-)
BR,
-R
next prev parent reply other threads:[~2018-11-29 18:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:03 [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg* Vivek Gautam
2018-11-29 14:14 ` Christoph Hellwig
2018-11-29 14:25 ` Rob Clark
2018-11-29 14:42 ` Rob Clark
2018-11-29 15:54 ` Christoph Hellwig
2018-11-29 18:48 ` Rob Clark
2018-11-29 19:40 ` Jordan Crouse
2018-11-29 19:57 ` Tomasz Figa
2018-11-29 20:03 ` Robin Murphy
2018-11-30 0:23 ` Tomasz Figa
2018-12-01 2:05 ` Tomasz Figa
2018-12-01 11:46 ` Rob Clark
2018-12-03 0:12 ` Tomasz Figa
2018-11-29 14:43 ` Daniel Vetter
2018-11-29 15:57 ` Christoph Hellwig
2018-11-29 16:28 ` Daniel Vetter
2018-11-29 16:57 ` Christoph Hellwig
2018-11-29 17:09 ` Daniel Vetter
2018-11-29 17:24 ` Tomasz Figa
2018-11-29 18:35 ` Christoph Hellwig
2018-11-29 18:57 ` Rob Clark [this message]
2018-11-30 9:40 ` Daniel Vetter
2018-11-30 9:35 ` Daniel Vetter
2018-11-30 9:44 ` Christoph Hellwig
2018-11-29 18:33 ` Christoph Hellwig
2018-11-30 9:46 ` Daniel Vetter
2018-12-07 1:38 ` Christoph Hellwig
2018-12-07 14:29 ` Rob Clark
2018-11-29 17:33 ` Brian Starkey
2018-11-29 18:35 ` Christoph Hellwig
2018-11-30 1:15 ` Rob Clark
2018-11-30 9:35 ` Christoph Hellwig
2018-11-29 15:53 ` Christoph Hellwig
2018-11-29 18:44 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF6AEGsT9RO2RmgBTa0HQRjRUiRKy9N3vQxvD7RVWp4HpnWn+w@mail.gmail.com \
--to=robdclark@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).