From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751865AbdEBKUK (ORCPT ); Tue, 2 May 2017 06:20:10 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33870 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdEBKUI (ORCPT ); Tue, 2 May 2017 06:20:08 -0400 MIME-Version: 1.0 In-Reply-To: <20170412191202.22740-2-eric@anholt.net> References: <20170412191202.22740-1-eric@anholt.net> <20170412191202.22740-2-eric@anholt.net> From: Rob Clark Date: Tue, 2 May 2017 06:20:06 -0400 Message-ID: Subject: Re: [PATCH v2 1/5] drm/msm: Expose our reservation object when exporting a dmabuf. To: Eric Anholt Cc: "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , stable , linux-arm-msm , freedreno Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 3:11 PM, Eric Anholt wrote: > Without this, polling on the dma-buf (and presumably other devices > synchronizing against our rendering) would return immediately, even > while the BO was busy. > > Signed-off-by: Eric Anholt > Reviewed-by: Daniel Vetter > Cc: stable@vger.kernel.org > Cc: Rob Clark > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org Reviewed-by: Rob Clark (go ahead and push via drm-misc with the rest of the series, if you haven't already) > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > drivers/gpu/drm/msm/msm_drv.h | 1 + > drivers/gpu/drm/msm/msm_gem_prime.c | 7 +++++++ > 3 files changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 9208e67be453..fe728a134e16 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -829,6 +829,7 @@ static struct drm_driver msm_driver = { > .prime_fd_to_handle = drm_gem_prime_fd_to_handle, > .gem_prime_export = drm_gem_prime_export, > .gem_prime_import = drm_gem_prime_import, > + .gem_prime_res_obj = msm_gem_prime_res_obj, > .gem_prime_pin = msm_gem_prime_pin, > .gem_prime_unpin = msm_gem_prime_unpin, > .gem_prime_get_sg_table = msm_gem_prime_get_sg_table, > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index b885c3d5ae4d..5e67fa66d483 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -223,6 +223,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj); > void *msm_gem_prime_vmap(struct drm_gem_object *obj); > void msm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); > int msm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma); > +struct reservation_object *msm_gem_prime_res_obj(struct drm_gem_object *obj); > struct drm_gem_object *msm_gem_prime_import_sg_table(struct drm_device *dev, > struct dma_buf_attachment *attach, struct sg_table *sg); > int msm_gem_prime_pin(struct drm_gem_object *obj); > diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c > index 60bb290700ce..13403c6da6c7 100644 > --- a/drivers/gpu/drm/msm/msm_gem_prime.c > +++ b/drivers/gpu/drm/msm/msm_gem_prime.c > @@ -70,3 +70,10 @@ void msm_gem_prime_unpin(struct drm_gem_object *obj) > if (!obj->import_attach) > msm_gem_put_pages(obj); > } > + > +struct reservation_object *msm_gem_prime_res_obj(struct drm_gem_object *obj) > +{ > + struct msm_gem_object *msm_obj = to_msm_bo(obj); > + > + return msm_obj->resv; > +} > -- > 2.11.0 >