From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077C2C4724C for ; Fri, 1 May 2020 18:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE37320787 for ; Fri, 1 May 2020 18:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vekpM1d5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730062AbgEASHa (ORCPT ); Fri, 1 May 2020 14:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729138AbgEASH3 (ORCPT ); Fri, 1 May 2020 14:07:29 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F9D5C061A0C; Fri, 1 May 2020 11:07:29 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id re23so8145908ejb.4; Fri, 01 May 2020 11:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u7uWdnXzReMILuWMuJCMVWJ56cZtnobswX6oBH/1+LI=; b=vekpM1d56g5fDbCG1IleQHXSiKBdPaYjvbDBn8cEraD0huZTUU0MxRbSdEavQx1Cw6 EfJ1ajFUGwUjFXkD1gx6qod2jw0GuCJt+K/gaLGFmOmikqEmXlXKAIVA9vZcK0mFbTh8 yFZyTENfGNSgrpjh0/iLYg3NfLkd7DC/BlT9PotgkO9H6qyhIIgAA3O/vj7dr3oFpyP9 /GG4sdRG/BtNvbeZokPrWxkUFJF0xSXcU/KH2ys2+PjRGFIgS9gY2wPSXDEIewMNPHFh Eg0rDnSqahbXmyU0i/FwPAdU4WNkffDNX0IugVwNMGQhQn/RXBLXvpDHafy6WGRTwWT6 k2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u7uWdnXzReMILuWMuJCMVWJ56cZtnobswX6oBH/1+LI=; b=tJyny85eRSHkH6wJ+5PQ2YMJojLAI5X7zqaxTn3NiwZJbkrRziCPYqaxpLcEdRzMlI SX35jySeG5Y21b/WbI+bJ/op8Cb6lte937rYxyjX4n+mSlWuNrdwLvsVDgkdQO5UBsfM TG3T+lg5rnIdaCLnDfrx7F42ttJqdS4yiP1D+Ejo1JbZKDp+RcnXxolNdti9mxT05z4g fiMBlZ8VLKJ8OYldGXClUI2mrGym2iInmb9+hrimaKUP627ORUrnZK9hu1Tz4XnqCjzO ZEBgl2t6S7rsq0afpbK/beDO+RCAF1NwP90kiVqVUdne3l/rVn7c+9WJtMXMQxqZAqmh pcpw== X-Gm-Message-State: AGi0PuaYC9bgZ5Q2ieZNVBPoiNGY0bhLTu+MHJZsy74yHwSOtj8RnJ4B kqIn0NrO2yDqTIyhhCeo4FAHssJQO+HvXj9f1bk= X-Google-Smtp-Source: APiQypKGvYoGXVQMOaMMGuLG6ZVr8NMMUDLLVypjF+0BH0k/Zjptcxe8gMGO+JVPHbaw6NNSXzHRZRexKuHsnVIIv94= X-Received: by 2002:a17:906:970e:: with SMTP id k14mr4444610ejx.202.1588356447735; Fri, 01 May 2020 11:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20200430192427.4104899-1-bjorn.andersson@linaro.org> In-Reply-To: <20200430192427.4104899-1-bjorn.andersson@linaro.org> From: Rob Clark Date: Fri, 1 May 2020 11:07:32 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Fix undefined "rd_full" link error To: Bjorn Andersson Cc: Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , linux-arm-msm , dri-devel , freedreno , Linux Kernel Mailing List , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 12:25 PM Bjorn Andersson wrote: > > rd_full should be defined outside the CONFIG_DEBUG_FS region, in order > to be able to link the msm driver even when CONFIG_DEBUG_FS is disabled. > > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers") > Reported-by: Stephen Rothwell > Signed-off-by: Bjorn Andersson thanks, Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_rd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c > index 732f65df5c4f..fea30e7aa9e8 100644 > --- a/drivers/gpu/drm/msm/msm_rd.c > +++ b/drivers/gpu/drm/msm/msm_rd.c > @@ -29,8 +29,6 @@ > * or shader programs (if not emitted inline in cmdstream). > */ > > -#ifdef CONFIG_DEBUG_FS > - > #include > #include > #include > @@ -47,6 +45,8 @@ bool rd_full = false; > MODULE_PARM_DESC(rd_full, "If true, $debugfs/.../rd will snapshot all buffer contents"); > module_param_named(rd_full, rd_full, bool, 0600); > > +#ifdef CONFIG_DEBUG_FS > + > enum rd_sect_type { > RD_NONE, > RD_TEST, /* ascii text */ > -- > 2.24.0 >