From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbbDINuA (ORCPT ); Thu, 9 Apr 2015 09:50:00 -0400 Received: from mail-qg0-f43.google.com ([209.85.192.43]:36831 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbbDINt6 (ORCPT ); Thu, 9 Apr 2015 09:49:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150409112240.GA4748@station.rsr.lip6.fr> References: <20150409112240.GA4748@station.rsr.lip6.fr> Date: Thu, 9 Apr 2015 09:49:58 -0400 Message-ID: Subject: Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING From: Rob Clark To: Valentin Rothberg Cc: Hai Li , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , David Airlie , Paul Bolle , rupran@einserver.de, stefan.hengelein@fau.de Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg wrote: > Hi Hai, > > your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm > driver") in today's Linux next tree adds an #ifdef with CONFIG_MSM_BUS_SCALING > as condition. MSM_BUS_SCALING is not defined in Kconfig, so the code in this > #ifdef block won't be compiled at its current state. > > I saw some references on this Kconfig option in other files; is there a > reason for the absence of MSM_BUS_SCALING? right now, it is something that only exists in downstream kernels (for example, android device kernels).. but in those kernels it is mandatory to use, as by default the memory/bus is downclocked and the display would underflow if we did not request sufficient bandwidth. It only exists right now in the upstream kernel to simplify backporting to various device kernels BR, -R > I found this issue with ./scripts/checkkconfigsymbols.py by diffing yesterday's > and today's next tree. > > Kind regards, > Valentin