From: Rob Clark <robdclark@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Johannes Berg <johannes@sipsolutions.net>,
Greg KH <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"swboyd@chromium.org" <swboyd@chromium.org>,
"khsieh@codeaurora.org" <khsieh@codeaurora.org>,
"nganji@codeaurora.org" <nganji@codeaurora.org>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
"aravindh@codeaurora.org" <aravindh@codeaurora.org>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins
Date: Tue, 1 Mar 2022 09:45:39 -0800 [thread overview]
Message-ID: <CAF6AEGtNGJanJ9f2pkjst50yPSWGJPo5nDkcZZgq=BkRWMq4yg@mail.gmail.com> (raw)
In-Reply-To: <8fa2f879e33e4e42b76e21c6fbdcb023@AcuMS.aculab.com>
On Mon, Feb 28, 2022 at 10:49 PM David Laight <David.Laight@aculab.com> wrote:
>
> From: Abhinav Kumar
> > Sent: 28 February 2022 21:38
> ...
> > We also did some profiling around how much increasing the block size
> > helps and here is the data:
> >
> > Block size cost
> >
> > 4KB 229s
> > 8KB 86s
>
> You must have an O(n^2) operation in there - find it.
The problem is how the devcoredump/sysfs interface works, which
results in "re-rendering" the output for each block.. it's fine for
moderate size sysfs files, but scales quite badly once you get into
couple MB size sysfs files.
It could be fixed by having some way to keep state across successive
read callbacks.
BR,
-R
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-03-01 17:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 19:44 [PATCH] devcoredump: increase the device delete timeout to 10 mins Abhinav Kumar
2022-02-08 20:35 ` Johannes Berg
2022-02-08 21:04 ` Abhinav Kumar
2022-02-08 21:12 ` Johannes Berg
2022-02-08 21:40 ` Abhinav Kumar
2022-02-08 21:54 ` Johannes Berg
2022-02-09 1:55 ` Abhinav Kumar
2022-02-09 7:50 ` Johannes Berg
2022-02-09 16:29 ` Abhinav Kumar
2022-02-11 11:09 ` Greg KH
2022-02-11 11:09 ` Greg KH
2022-02-11 18:59 ` Abhinav Kumar
2022-02-12 7:04 ` Greg KH
2022-02-12 7:52 ` Abhinav Kumar
2022-02-12 8:24 ` Johannes Berg
2022-02-12 8:35 ` Abhinav Kumar
2022-02-28 21:38 ` Abhinav Kumar
2022-03-01 6:48 ` David Laight
2022-03-01 17:45 ` Rob Clark [this message]
2022-03-11 11:53 ` Johannes Berg
2022-02-12 8:29 ` Greg KH
2022-02-12 8:33 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6AEGtNGJanJ9f2pkjst50yPSWGJPo5nDkcZZgq=BkRWMq4yg@mail.gmail.com' \
--to=robdclark@gmail.com \
--cc=David.Laight@aculab.com \
--cc=aravindh@codeaurora.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nganji@codeaurora.org \
--cc=quic_abhinavk@quicinc.com \
--cc=rafael@kernel.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).