From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30E3C433E0 for ; Sun, 21 Jun 2020 16:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDE6D21532 for ; Sun, 21 Jun 2020 16:50:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WC/NqBMG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730448AbgFUQuS (ORCPT ); Sun, 21 Jun 2020 12:50:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730411AbgFUQuR (ORCPT ); Sun, 21 Jun 2020 12:50:17 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F420C061794; Sun, 21 Jun 2020 09:50:17 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id n24so15499036ejd.0; Sun, 21 Jun 2020 09:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8/oeYmT0gf/BQf5rhsOaYvoPP5ayrLP9PM0KP+IAgfg=; b=WC/NqBMGWLqBQRZbzUo1d4ajwpofeyOODarATg8fVi1KkjU+anC7Pom0DeZCqPelxu XrRcKDvuIBUgVs3cUzYJOC83XgFBC6pKZU8C34sw0ONUdCf4N/dnOWPj+oqhEuznsnKV oZFMQCqtevhZdAGtoZVIBpcM1s77qdqWW5yxbGI7Bes0hQCUV5mUlIDKESpVEJ2u7QLF mGeRJYH1uJNJIq0/VOje77BpxGIZU+rTJ40DdB6jFYppD/f4VRxhIceQHkGwFB83P/OI TA2jMQDCisNagqz/E/xuwDfOlPtEHywOhE2n7JGq8Ttq2YqVjmiCafXBQEP609cC6L1q espA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/oeYmT0gf/BQf5rhsOaYvoPP5ayrLP9PM0KP+IAgfg=; b=rlRnCOnFHfe8d1RJ/A5Fxw+3pxmpjT4lBwe+eQMnRzvOGAd8sla/cDTl/6aX3ZdQp0 FPT/PGKb72ax6GnNrkN9dmHIST/YqeonJzbmECFi1z9Yx+YjdDepMo8FZCd+g3m6A6ID ocNQ6jXzGyu5ys+jPPWakoUqVnuShSnjKk78rHhKW8h664MDWhYzd6mLp/HCBkF0ebPf dgHIEWHFbdaOX44i0dBLkJm6Z0g/sI8CFSZ0K9XY1paBU6FjIBFVlFiY8Sh6n3hcBQB+ d+vKZe6CN16yHphVegNsncv1UQKbWgvrP3i0knaKShvMeSYB9TxeAvEg9k7XQb2Otncs nV4g== X-Gm-Message-State: AOAM532NuKj75uB0zJ2PpD7eQZxLzUlRCYw+dq7rFp4v7UVmK1ACGhv7 dM81Tb6KuMxhsYGvLtI9ic2oI40lFD6vkQDEJiw= X-Google-Smtp-Source: ABdhPJxSdA2O9bfRHd4FEkpgAkg0zBjCVSJMWG2BUWgw83KJC+QN/PKfGTm3H9P6BtV5cQTTx+7xynA2gzaW3NiUvAM= X-Received: by 2002:a17:906:856:: with SMTP id f22mr3072421ejd.245.1592758215478; Sun, 21 Jun 2020 09:50:15 -0700 (PDT) MIME-Version: 1.0 References: <3c186284280c37c76cf77bf482dde725359b8a8a.1586382357.git.asutoshd@codeaurora.org> <20200621075539.GK128451@builder.lan> In-Reply-To: <20200621075539.GK128451@builder.lan> From: Rob Clark Date: Sun, 21 Jun 2020 09:50:43 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support To: Bjorn Andersson Cc: Avri Altman , Asutosh Das , "cang@codeaurora.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , linux-arm-msm , Subhash Jadavani , Alim Akhtar , "James E.J. Bottomley" , Bean Huo , Stanley Chu , Tomas Winkler , Colin Ian King , Bart Van Assche , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 21, 2020 at 12:58 AM Bjorn Andersson wrote: > > On Sun 21 Jun 00:40 PDT 2020, Avri Altman wrote: > > > > > > > > > On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das > > > wrote: > > > > > > > > The write performance of TLC NAND is considerably > > > > lower than SLC NAND. Using SLC NAND as a WriteBooster > > > > Buffer enables the write request to be processed with > > > > lower latency and improves the overall write performance. > > > > > > > > Adds support for shared-buffer mode WriteBooster. > > > > > > > > WriteBooster enable: SW enables it when clocks are > > > > scaled up, thus it's enabled only in high load conditions. > > > > > > > > WriteBooster disable: SW will disable the feature, > > > > when clocks are scaled down. Thus writes would go as normal > > > > writes. > > > > > > btw, in v5.8-rc1 (plus handful of remaining patches for lenovo c630 > > > laptop (sdm850)), I'm seeing a lot of: > > > > > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > > idn 14 failed, err = 253 > > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > > idn 14 failed, err = 253 > > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag_retry: query attribute, > > > opcode 6, idn 14, failed with error 253 after 3 retires > > > ufshcd-qcom 1d84000.ufshc: ufshcd_wb_ctrl write booster enable failed 253 > > > > > > and at least subjectively, compiling mesa seems slower, which seems > > > like it might be related? > > This looks like a device issue to be taken with the flash vendor: > > There's no way for a end-user to file a bug report with the flash vendor > on a device bought from an OEM and even if they would accept the bug > report they wouldn't re-provision the flash in an shipped device. > > So you will have to work around this in the driver. oh, ugg.. well I think these msgs from dmesg identify the part if we end up needing to use a denylist: scsi 0:0:0:49488: Well-known LUN SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 scsi 0:0:0:49476: Well-known LUN SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 scsi 0:0:0:49456: Well-known LUN SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 scsi 0:0:0:0: Direct-Access SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 scsi 0:0:0:1: Direct-Access SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 sd 0:0:0:0: [sda] 29765632 4096-byte logical blocks: (122 GB/114 GiB) sd 0:0:0:0: [sda] Write Protect is off sd 0:0:0:0: [sda] Mode Sense: 00 32 00 10 sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA sd 0:0:0:0: [sda] Optimal transfer size 786432 bytes scsi 0:0:0:2: Direct-Access SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 scsi 0:0:0:3: Direct-Access SKhynix H28S8Q302CMR A102 PQ: 0 ANSI: 6 (otoh I guess the driver could just notice that writeboost keeps failing and stop trying to use it) BR, -R > Regards, > Bjorn > > > The device reports that it supports wd, but returns inalid idn for flag 0xe... > > > > Thanks, > > Avri