From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F29C76194 for ; Thu, 25 Jul 2019 17:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 721BC20659 for ; Thu, 25 Jul 2019 17:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bCgV0Y0K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729994AbfGYRvF (ORCPT ); Thu, 25 Jul 2019 13:51:05 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37791 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbfGYRvF (ORCPT ); Thu, 25 Jul 2019 13:51:05 -0400 Received: by mail-ed1-f65.google.com with SMTP id w13so51035148eds.4; Thu, 25 Jul 2019 10:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rLx1WxxS2eiFupzGOfH7X3JpoyBVgunYKBsWNt5yLUw=; b=bCgV0Y0KK+hZmQcR1Ije8gmw+VFkvFkFIk7n6PTSK4+JTJutIG+r8glT/WEdzuFC10 O3KQ4Siab33aiSEyEsyVYzHGz/nsrTIerU+zKakzfKJf4AMYChTdkwaNgn70ISdnNF3c TLSUlrxjEMfU+AYpWgjfD92PU+aG7Wdh4ZlNR0UEV+INBwHfjkgCfyqB3c9aQxux/GIF /JNsbzuvL4tYp+0BsS2aeaToEyI8t1OuTNiG9EtNGBpV3IviSxEx6Jkv2tedyJlpVIMf bJc+oDf9i99jxX1rArWlfw4m4NL/MpETs01X74VX5XoLRBZE/jAVi7B0aYpWfHywarah jvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rLx1WxxS2eiFupzGOfH7X3JpoyBVgunYKBsWNt5yLUw=; b=Ajq3ff3yw9QYdg5esNuProiKm/rPY+x9J0QPOndKs5gIt7kJHm2hI00F+oY9s/XD+t 99CSm2m6XU2hz6gGCu6LDlQL441Bg9/0hgtQujTN41HvgVx5oOczwI2IJTyRufpZBJ8f Ht7AgcvKmSH5qR654tnI/dY0oCnkOxAuPVIhCiEruNcxE1AkNBX1I6pKzuVV9pTvwKHr M7Js/KJ158V4CS7dfmuLrhXEBootoFRzbjmysjVE1gr5J5l7epc9GgSahTkJHexf82Pe uiCOzeMnSNZWSG9m9hTRyeDKwacZ7kQF11HpivrkYEdMK9NUXWlHCgFhu/mK3LYR7Gkx QXxA== X-Gm-Message-State: APjAAAVGjSKR3u8gDjkKHhZw8R/5nZDnsWaXWfuvgKetITDApQrpr73X o0uzVbte2m7UiZvH6zBacB2mdPYMeGZfryphBGE= X-Google-Smtp-Source: APXvYqx0hq85a8gR6SvZiwDeUgHmw4HBnllzoppGUeegEPb0sAcSwB9g+0T/RlSOGs1+9qmJErJLRLdvNOJgJ7TKSlg= X-Received: by 2002:a17:906:f85:: with SMTP id q5mr70131087ejj.192.1564077063087; Thu, 25 Jul 2019 10:51:03 -0700 (PDT) MIME-Version: 1.0 References: <1564073588-27386-1-git-send-email-jcrouse@codeaurora.org> In-Reply-To: <1564073588-27386-1-git-send-email-jcrouse@codeaurora.org> From: Rob Clark Date: Thu, 25 Jul 2019 10:50:51 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Annotate intentional switch statement fall throughs To: Jordan Crouse Cc: freedreno , linux-arm-msm , David Airlie , Sean Paul , Kees Cook , Thomas Zimmermann , Sharat Masetty , dri-devel , Linux Kernel Mailing List , Douglas Anderson , Thomas Gleixner , Jonathan Marek , Greg Kroah-Hartman , Jeffrey Hugo , Mamta Shukla , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 9:53 AM Jordan Crouse wrote: > > Explicitly mark intentional fall throughs in switch statements to keep > -Wimplicit-fallthrough from complaining. > > Signed-off-by: Jordan Crouse Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > index 1671db4..e9c55d1 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > @@ -59,6 +59,7 @@ static void a5xx_submit_in_rb(struct msm_gpu *gpu, struct msm_gem_submit *submit > case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: > if (priv->lastctx == ctx) > break; > + /* fall-thru */ > case MSM_SUBMIT_CMD_BUF: > /* copy commands into RB: */ > obj = submit->bos[submit->cmd[i].idx].obj; > @@ -149,6 +150,7 @@ static void a5xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, > case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: > if (priv->lastctx == ctx) > break; > + /* fall-thru */ > case MSM_SUBMIT_CMD_BUF: > OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); > OUT_RING(ring, lower_32_bits(submit->cmd[i].iova)); > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index be39cf0..dc8ec2c 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -115,6 +115,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, > case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: > if (priv->lastctx == ctx) > break; > + /* fall-thru */ > case MSM_SUBMIT_CMD_BUF: > OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); > OUT_RING(ring, lower_32_bits(submit->cmd[i].iova)); > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 9acbbc0..048c8be 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -428,6 +428,7 @@ void adreno_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, > /* ignore if there has not been a ctx switch: */ > if (priv->lastctx == ctx) > break; > + /* fall-thru */ > case MSM_SUBMIT_CMD_BUF: > OUT_PKT3(ring, adreno_is_a430(adreno_gpu) ? > CP_INDIRECT_BUFFER_PFE : CP_INDIRECT_BUFFER_PFD, 2); > -- > 2.7.4 >