From: Rob Clark <robdclark@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Krishna Manikandan <mkrishn@codeaurora.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
"Kristian H. Kristensen" <hoegsberg@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Jeykumar Sankaran <jsanka@codeaurora.org>,
Raviteja Tamatam <travitej@codeaurora.org>,
nganji@codeaurora.org
Subject: Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target
Date: Thu, 10 Sep 2020 15:04:47 -0700 [thread overview]
Message-ID: <CAF6AEGvriNYkeaBVmK2mEG1OVojun2nQ7c2X6BuE-E-B4DRujA@mail.gmail.com> (raw)
In-Reply-To: <20200910220037.GA472@uller>
On Thu, Sep 10, 2020 at 3:00 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote:
>
> > From: Krishna Manikandan <mkrishn@codeaurora.org>
> >
> > Move the bus clock to mdp device node,in order
> > to facilitate bus band width scaling on sc7180
> > target.
> >
> > The parent device MDSS will not vote for bus bw,
> > instead the vote will be triggered by mdp device
> > node. Since a minimum vote is required to turn
> > on bus clock, move the clock node to mdp device
> > from where the votes are requested.
> >
> > This patch has dependency on the below series
> > https://patchwork.kernel.org/patch/11468783/
> >
>
> Isn't this dependency on an old revision of patch 3/3 in this series?
>
> Regardless, I don't see either the linked patch or patch 3 merged in
> linux-next, so I presume I should not merge this?
I guess that would be "drm/msm/dpu: add support for clk and bw scaling
for display" on msm-next-staging[1] (about to be msm-next)
[1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-staging
> Regards,
> Bjorn
>
> > Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 4f2c0d1..31fed6d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -1510,10 +1510,9 @@
> > power-domains = <&dispcc MDSS_GDSC>;
> >
> > clocks = <&gcc GCC_DISP_AHB_CLK>,
> > - <&gcc GCC_DISP_HF_AXI_CLK>,
> > <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_CLK>;
> > - clock-names = "iface", "bus", "ahb", "core";
> > + clock-names = "iface", "ahb", "core";
> >
> > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
> > assigned-clock-rates = <300000000>;
> > @@ -1539,12 +1538,13 @@
> > <0 0x0aeb0000 0 0x2008>;
> > reg-names = "mdp", "vbif";
> >
> > - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
> > + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > <&dispcc DISP_CC_MDSS_ROT_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_CLK>,
> > <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> > - clock-names = "iface", "rot", "lut", "core",
> > + clock-names = "bus", "iface", "rot", "lut", "core",
> > "vsync";
> > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
> > <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> > --
> > 1.9.1
> >
next prev parent reply other threads:[~2020-09-10 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 11:35 [PATCH 1/3] arm64: dts: sc7180: add interconnect bindings for display Kalyan Thota
2020-07-16 11:35 ` [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target Kalyan Thota
2020-08-04 15:43 ` Rob Clark
2020-09-10 22:00 ` Bjorn Andersson
2020-09-10 22:04 ` Rob Clark [this message]
2020-07-16 11:35 ` [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display Kalyan Thota
2020-08-04 15:40 ` Rob Clark
2020-10-27 8:32 ` Dmitry Baryshkov
2020-11-08 17:55 ` Amit Pundir
2020-08-04 15:42 ` [PATCH 1/3] arm64: dts: sc7180: add interconnect bindings " Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF6AEGvriNYkeaBVmK2mEG1OVojun2nQ7c2X6BuE-E-B4DRujA@mail.gmail.com \
--to=robdclark@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=jsanka@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=nganji@codeaurora.org \
--cc=seanpaul@chromium.org \
--cc=travitej@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).