Re: [PATCH] CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie

[Rob Clark <robdclark@gmail.com>]

On Wed, Mar 30, 2022 at 2:58 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Wed, Mar 30, 2022 at 05:09:46PM +0800, Mars Chen wrote:
>
> > Subject: CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie
>
> No CHROMIUM tag for upstream posts.
>
> > Initial attempt at Gelarshie device tree.
>
> This is not very useful. If you don't want to reveal much information
> about an unreleased device you could say something generic like
> "Add device tree for Gelarshie, a trogdor variant".
>
> > BUG=b:225756600
> > TEST=emerge-strongbad chromeos-kernel-5_4
>
> drop these
>
> > Signed-off-by: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  .../dts/qcom/sc7180-trogdor-gelarshie-r0.dts  |  15 +
> >  .../dts/qcom/sc7180-trogdor-gelarshie.dtsi    | 304 ++++++++++++++++++
> >  3 files changed, 320 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index f9e6343acd03..cf8f88b065c3 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -57,6 +57,7 @@ dtb-$(CONFIG_ARCH_QCOM)     += sc7180-trogdor-coachz-r1.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-coachz-r1-lte.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-coachz-r3.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-coachz-r3-lte.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-gelarshie-r0.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-homestar-r2.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-homestar-r3.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-homestar-r4.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> > new file mode 100644
> > index 000000000000..027d6d563a5f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Google Gelarshie board device tree source
> > + *
> > + * Copyright 2022 Google LLC.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sc7180-trogdor-gelarshie.dtsi"
> > +
> > +/ {
> > +     model = "Google Gelarshie (rev0+)";
> > +     compatible = "google,gelarshie", "qcom,sc7180";
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi
> > new file mode 100644
> > index 000000000000..842f6cac6c27
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi
> > @@ -0,0 +1,304 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Google Gelarshie board device tree source
> > + *
> > + * Copyright 2022 Google LLC.
> > + */
> > +
> > +#include "sc7180.dtsi"
> > +#include "sc7180-trogdor-mipi-camera.dtsi"
>
> drop the mipi camera include, it is not upstream
>
> > +
> > +ap_ec_spi: &spi6 {};
> > +ap_h1_spi: &spi0 {};
> > +
> > +#include "sc7180-trogdor.dtsi"
> > +#include "sc7180-trogdor-ti-sn65dsi86.dtsi"
> > +
> > +/* Deleted nodes from trogdor.dtsi */
> > +
> > +/delete-node/ &alc5682;
> > +/delete-node/ &pp3300_codec;
> > +
> > +/ {
> > +     /* BOARD-SPECIFIC TOP LEVEL NODES */
> > +
> > +     adau7002: audio-codec-1 {
> > +             compatible = "adi,adau7002";
> > +             IOVDD-supply = <&pp1800_l15a>;
> > +             wakeup-delay-ms = <80>;
> > +             #sound-dai-cells = <0>;
> > +     };
> > +};
> > +
> > +&backlight {
> > +     pwms = <&cros_ec_pwm 0>;
> > +};
> > +
> > +&camcc {
> > +     status = "okay";
> > +};
> > +
> > +&cros_ec {
> > +     cros_ec_proximity: proximity {
> > +             compatible = "google,cros-ec-mkbp-proximity";
> > +             label = "proximity-wifi";
> > +     };
> > +};
> > +
> > +ap_ts_pen_1v8: &i2c4 {
> > +     status = "okay";
> > +     clock-frequency = <400000>;
> > +
> > +     ap_ts: touchscreen@5d {
> > +             compatible = "goodix,gt7375p";
> > +             reg = <0x5d>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
> > +
> > +             interrupt-parent = <&tlmm>;
> > +             interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +             reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> > +
> > +             vdd-supply = <&pp3300_ts>;
> > +     };
> > +};
> > +
> > +&i2c7 {
> > +     status = "disabled";
> > +};
> > +
> > +&i2c9 {
> > +     status = "disabled";
> > +};
> > +
> > +&mdp {
> > +     chromium-enable-overlays;
> > +};
>
> I can't find documentation for 'chromium-enable-overlays', what is this
> supposed to do?

it's a downstream workaround .. this can be dropped from upstream dt

BR,
-R

> > +
> > +&panel {
> > +     compatible = "edp-panel";
> > +};
> > +
> > +&pm6150_adc {
> > +     skin-temp-thermistor@4e {
> > +             reg = <ADC5_AMUX_THM2_100K_PU>;
> > +             qcom,ratiometric;
> > +             qcom,hw-settle-time = <200>;
> > +     };
> > +};
> > +
> > +&pm6150_adc_tm {
> > +     status = "okay";
> > +
> > +     skin-temp-thermistor@1 {
> > +             reg = <1>;
> > +             io-channels = <&pm6150_adc ADC5_AMUX_THM2_100K_PU>;
> > +             qcom,ratiometric;
> > +             qcom,hw-settle-time-us = <200>;
> > +     };
> > +};
>
> The thermistor is currently unused, drop it and add it later when you
> add the corresponding thermal zone.
>
> > +
> > +&pp1800_uf_cam {
> > +     status = "okay";
> > +};
> > +
> > +&pp1800_wf_cam {
> > +     status = "okay";
> > +};
> > +
> > +&pp2800_uf_cam {
> > +     status = "okay";
> > +};
> > +
> > +&pp2800_wf_cam {
> > +     status = "okay";
> > +};
> > +
> > +&pp3300_dx_edp {
> > +     gpio = <&tlmm 67 GPIO_ACTIVE_HIGH>;
> > +};
> > +
> > +&sdhc_2 {
> > +     status = "okay";
> > +};
> > +
> > +&sn65dsi86_out {
> > +     data-lanes = <0 1 2 3>;
> > +};
> > +
> > +&sound {
> > +     compatible = "google,sc7180-coachz";
>
> Is 'sc7180-coachz' intended because the config is the same as for
> coachz or should this be 'sc7180-gelarshie'?