From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbcHAXSC (ORCPT ); Mon, 1 Aug 2016 19:18:02 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:34363 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754402AbcHAXRo (ORCPT ); Mon, 1 Aug 2016 19:17:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <1468425977-4819-1-git-send-email-benjamin.tissoires@redhat.com> From: Ping Cheng Date: Mon, 1 Aug 2016 16:17:10 -0700 Message-ID: Subject: Re: [PATCH v2 00/30] HID: wacom: cleanup/EKR/LED To: Jiri Kosina Cc: Benjamin Tissoires , "linux-kernel@vger.kernel.org" , linux-input , Aaron Skomra Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, This patchset has gone through two rounds of testing/review. It is also a necessary set to support future userland LED configuration features. Do you see any issues with the patches? Cheers, Ping On Wed, Jul 13, 2016 at 2:36 PM, Aaron Armstrong Skomra wrote: > On Wed, Jul 13, 2016 at 9:05 AM, Benjamin Tissoires > wrote: >> Hi, >> >> So this is a v2 of my summer cleanup of the wacom driver. >> I fixed the remarks from everybody I think, and it should be in a better shape >> now. >> I removed the patch that changed the LED banks ordering as libwacom exports it >> that way. I also added 3 extra patches for the power_supply to be a little bit >> more user friendly in gnome-control-center (well, upowerd). >> >> Thanks for double testing on the Cintiq 21UX2 and the 24HD as I could only > > Retested on the 21UX2 and the 24HD. > > Tested-by Aaron Armstrong Skomra > > Best, > Aaron > >> compare the raw events to what was expected, and nothing is better than actual >> testing with real hardware. >> >> Cheers, >> Benjamin >> >> Benjamin Tissoires (30): >> HID: wacom: actually report the battery level for wireless connected >> HID: wacom: store the type in wacom->shared for INTUOSHT and INTUOSHT2 >> HID: wacom: remove cleanup of wacom->remote_dir from >> wacom_clean_inputs() >> HID: wacom: untie leds from inputs >> HID: wacom: use one work queue per task >> HID: wacom: switch battery to devres >> HID: wacom: switch inputs to devres >> HID: wacom: put the managed resources in a group >> HID: wacom: convert LEDs to devres >> HID: wacom: use devm_kasprintf for allocating the name of the remote >> HID: wacom: use devres to allocate driver data >> HID: wacom: devres manage the shared data too >> HID: wacom: leds: dynamically allocate LED groups >> HID: wacom: EKR: add a worker to add/remove resources on >> addition/removal >> HID: wacom: EKR: have the wacom resources dynamically allocated >> HID: wacom: rework fail path in probe() and parse_and_register() >> HID: wacom: EKR: have proper allocator and destructor >> HID: wacom: EKR: use devres groups to manage resources >> HID: wacom: EKR: have one array of struct remotes instead of many >> arrays >> HID: wacom: EKR: allocate one input node per remote >> HID: wacom: EKR: have one power_supply per remote >> HID: wacom: EKR: attach the power_supply on first connection >> HID: wacom: leds: use the ledclass instead of custom made sysfs files >> HID: wacom: leds: actually release the LEDs on disconnect >> HID: wacom: leds: handle the switch of the LEDs directly in the kernel >> HID: wacom: leds: make sure Cintiq 21UX2 and 24HD control the right >> LEDs >> HID: wacom: leds: handle Cintiq 24HD leds buttons >> HID: wacom: power_supply: mark the type as USB >> HID: wacom: power_supply: remove ac information >> HID: wacom: power_supply: provide the actual model_name >> >> Documentation/ABI/testing/sysfs-driver-wacom | 5 + >> drivers/hid/Kconfig | 1 + >> drivers/hid/wacom.h | 96 ++- >> drivers/hid/wacom_sys.c | 1104 ++++++++++++++++++-------- >> drivers/hid/wacom_wac.c | 254 ++++-- >> drivers/hid/wacom_wac.h | 19 +- >> 6 files changed, 1058 insertions(+), 421 deletions(-) >> >> -- >> 2.5.5 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html