From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99379C04AB6 for ; Tue, 28 May 2019 17:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F90E21726 for ; Tue, 28 May 2019 17:12:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="elCiHPbe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727356AbfE1RMD (ORCPT ); Tue, 28 May 2019 13:12:03 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:45417 "EHLO mail-ed1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfE1RMD (ORCPT ); Tue, 28 May 2019 13:12:03 -0400 Received: by mail-ed1-f47.google.com with SMTP id g57so18002494edc.12; Tue, 28 May 2019 10:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lYImdE1K3cUe2xPFfKctCk0xbs1kFjS1GtFoys4OKEc=; b=elCiHPbeF+3BBhnD/fPMTklieZ6tyszuUka6t0KBE7hW2jdKkIboHAtr25j9U95Ikf SR3t7R2wiTTMWcxf6u57nFDB1rYVtF62i57wVAJy1V+qT3ODXA7vw+48/1p9QfEAw9vY DJl0xtovDV+V4awLz00+qFO1WJDc8lLT7dkPYd6XqRr70FHdTOUG/5hF9qC4mmAkntHu bcyEqiiMQXF9pVYSYJrJI3prNpAgmZBe15Z9fNX+yf9F644uNPXzhU1sSOshy8aDUp/W feiD9ySMIUcHhvNQ6Kb7ctoHYRqqebGN6QPFHqzlxm6aBLO3Y6Wx0OygowJJiPaIpyaQ +aAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lYImdE1K3cUe2xPFfKctCk0xbs1kFjS1GtFoys4OKEc=; b=gkjukjqnUTTW2RRr6sLqd7HEDChRs8F98gW7M4X9Q3p93CzPU9Vio4U9aEeP4j3mpN 2WKiLbyMPdNKnO/6VFgLZbP6TA6XyQ7bC5/9235SgJcG1GD5ZK8kiJAcn9TMeJAAI3N2 rrIQ83g0WBx7JErCFY0JATzSvqqqwQktboSjZSE/J86urFE7C9jQ19TKIXZgSQpinqSl yqj8P3seFh5mzGnJkDs/JoRG9FiI5wADeBHJIjywPmrXvqmL1MFxY1EYrcNlxz4UwH3s AuFUlsdXN9j5KG11T3ZbbbGHhSpQ10Pqm0W2eFGshSaDFSD1IIrjbb3rpaAiiDPWsRNQ llpg== X-Gm-Message-State: APjAAAXl7Ynb9TsUtGqrCzBHaWN+Tp+3Mx53A12D/VcQ1rRJ/IlWtk2Z ntkVoLRLVwXZzbugpSwbXQgWIf0ja37i1cyKBZA= X-Google-Smtp-Source: APXvYqyAvOfbFAAK6aMyy93n7UREJlpiHInet91UkneecigYVrJX7593QPls/vDRXj8AibJ87Uas7h5rWHEPU6WqUys= X-Received: by 2002:a17:906:76c8:: with SMTP id q8mr70324783ejn.229.1559063521332; Tue, 28 May 2019 10:12:01 -0700 (PDT) MIME-Version: 1.0 References: <20190523210651.80902-1-fklassen@appneta.com> <20190523210651.80902-5-fklassen@appneta.com> <879E5DA6-3A4F-4CE1-9DA5-480EE30109DE@appneta.com> <5BB184F2-6C20-416B-B2AF-A678400CFE3E@appneta.com> <903DEC70-845B-4C4B-911D-2F203C191C27@appneta.com> <9811659B-6D5A-4C4F-9CF8-735E9CA6DE4E@appneta.com> In-Reply-To: From: Willem de Bruijn Date: Tue, 28 May 2019 13:11:24 -0400 Message-ID: Subject: Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue To: Fred Klassen Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Shuah Khan , Network Development , LKML , linux-kselftest@vger.kernel.org, Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Now that I know the issue is only in TCP, I can speculate that all bytes are > > being reported, but done with fewer messages. It may warrant some > > investigation in case there is some kind of bug. > > This would definitely still be a bug and should not happen. We have > quite a bit of experience with TCP zerocopy and I have not run into > this in practice, so I do think that it is somehow a test artifact. To be clear, I'm not saying that it is an artifact of your extensions. It's quite likely that the zerocopy benchmark was a bit flaky in that regard all along. No need to spend further time on that for this patchset.