From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93861C072B1 for ; Tue, 28 May 2019 20:09:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E89120B7C for ; Tue, 28 May 2019 20:09:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aMrOykYI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727924AbfE1UJq (ORCPT ); Tue, 28 May 2019 16:09:46 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:45360 "EHLO mail-ed1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbfE1UJq (ORCPT ); Tue, 28 May 2019 16:09:46 -0400 Received: by mail-ed1-f44.google.com with SMTP id g57so18751971edc.12; Tue, 28 May 2019 13:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lfHCjXdAucK32QgcRHWRo0qGiwkfsWt0JaYloVUGZf8=; b=aMrOykYI9DVuCfBXVLxQVyW1/LvVXswL14cMijeWdx6z6rYgK4R+gUCF8m4QGXl3GC PH2AX2SanfnRTvIcsED/auiDa8GgMJWc1HPb/GzwSeHbf9XbWEJJjCdMCBbhd1tHU5l6 oWFtcAnz/UppSHrWFQkMPoclKzVxPe+xPXfICEFPMTT0/zmhf+7vuCsYPO+p5HOp1DTg bVPKFGkYERvF62gaAVv03CueyoCR16ooiBIHG3Cv1ZNsyogwMRLWuXvvxiaXIKEwyn2A wbxe/Cf6WieOJeKpWugbNZ2uuahlrgBUrxYHBYBBqrr6S0K4TBIwbocYz2kpt6Q9pSgw 5gUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lfHCjXdAucK32QgcRHWRo0qGiwkfsWt0JaYloVUGZf8=; b=NnPPU/f0afTgF1k7SvjtyAMUNqq0zdTCQznuf7KngD6Os0b845fvyVlSBiAx6rpeHd HtnEKNh9dKOefOqBvY7xy23OvWcHXYJhGXW3IEq3N7qGNWlP1VQVtOzrsoaD9c+JiZkf Nher+UkzaLBKKsg/FPsOz1M3FL5rYuVkg2z0dQ9kQ1q1ivJfEFejCR0OUV8QyTMbR9Va i7XyZf/5+ctFUA0x2FUbt5cErf/yqvIUtS4M21/fXyIW4hakRB0oZJEriAAaxgvaFzfo a/sHRUkWMKt20g51yf62RUwgVrV1rSacP+zNoIk+i3m5rEaVXenfGTzDHJVcDkfhTFi8 HTGA== X-Gm-Message-State: APjAAAVC/h2+NjjXwiLwCDMKg5ifh/XEtn8myDZ5JFoy6Bp1e76nCcxh jGgZiO6k4ArZB/1rH89JxRUPDi1rGIxI24j+Hkw= X-Google-Smtp-Source: APXvYqzEOeZWC9L1vOMmqxVgoI1B8bDBS/QAi758qW8Lu/Q0XsVo+3caRyPLEpsaQ9+8ScyzX8Wa1c4SeLkbV4L9qVg= X-Received: by 2002:a17:907:397:: with SMTP id ss23mr6839098ejb.226.1559074184038; Tue, 28 May 2019 13:09:44 -0700 (PDT) MIME-Version: 1.0 References: <20190528184708.16516-1-fklassen@appneta.com> <20190528184708.16516-3-fklassen@appneta.com> In-Reply-To: <20190528184708.16516-3-fklassen@appneta.com> From: Willem de Bruijn Date: Tue, 28 May 2019 16:09:07 -0400 Message-ID: Subject: Re: [PATCH net-next v2 2/3] net/udpgso_bench.sh add UDP GSO audit tests To: Fred Klassen Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Shuah Khan , Network Development , LKML , linux-kselftest@vger.kernel.org, Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 3:24 PM Fred Klassen wrote: > > Audit tests count the total number of messages sent and compares > with total number of CMSG received on error queue. Example: > > udp gso zerocopy timestamp audit > udp rx: 1599 MB/s 1166414 calls/s > udp tx: 1615 MB/s 27395 calls/s 27395 msg/s > udp rx: 1634 MB/s 1192261 calls/s > udp tx: 1633 MB/s 27699 calls/s 27699 msg/s > udp rx: 1633 MB/s 1191358 calls/s > udp tx: 1631 MB/s 27678 calls/s 27678 msg/s > Summary over 4.000 seconds... > sum udp tx: 1665 MB/s 82772 calls (27590/s) 82772 msgs (27590/s) > Tx Timestamps: 82772 received 0 errors > Zerocopy acks: 82772 received 0 errors > > Errors are thrown if CMSG count does not equal send count, > example: > > Summary over 4.000 seconds... > sum tcp tx: 7451 MB/s 493706 calls (123426/s) 493706 msgs (123426/s) > ./udpgso_bench_tx: Unexpected number of Zerocopy completions: 493706 expected 493704 received > > Also reduce individual test time from 4 to 3 seconds so that > overall test time does not increase significantly. > > Signed-off-by: Fred Klassen Acked-by: Willem de Bruijn If respinning the series, please add a comment about adding -P to the tcp zerocopy test.