From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF551C433DB for ; Wed, 10 Feb 2021 14:52:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CBCE64E70 for ; Wed, 10 Feb 2021 14:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbhBJOwJ (ORCPT ); Wed, 10 Feb 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbhBJOwC (ORCPT ); Wed, 10 Feb 2021 09:52:02 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17E4DC061574; Wed, 10 Feb 2021 06:51:20 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id i8so4705610ejc.7; Wed, 10 Feb 2021 06:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OvXV28pKYZQ6XN2BS9VfvmXTJ0BIn3jo9mdDyBLMsno=; b=JHd97QPXdtdgWBVVFWf5uycI5zboNkqBWl6I7CyXj/rrhhwshsHn7XHwI1B+/vAXjW dnbNILCCJfBL8l7EdB9hJ+rI3wA2aMa4JMYVxGnPVai/J0qsx2YWGh/lQDffC45qYCbd CwNNnJKq0v1EYmIzcBpFOhuMcFCDZZas90G3OLMVxatwtofUqmnxL63wpAY3tRP+Fgks Ch5dN3ZinRZ8Pv+uWje0NfpxbSPlwKOoWh0KRmaUkHBfjLXPSJeAwj+c3butvbzOZUWK 0rCryg0nj4BnJXC9n/6xMRk+vn8qV54JeKErlcyPWzDT7GrcJqg8osSpMoYvO/6Gt2sS Y9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OvXV28pKYZQ6XN2BS9VfvmXTJ0BIn3jo9mdDyBLMsno=; b=dJCQffqWhSsx4anmgjnqVuWdadP8CykJ3D3H5tGgkS5aD8ztpdStmdBK4syuxjUSnu +zvxq9R0T6txZtihr/3iBZ5encGzoMh63TxKXwp/GNj9RODjm7Gzu3BfNVgGfhhGQATd FLrwlNg/LG1GI1j1xQF2TO/pVMlyskr7sRTw3NykzCTYmvNHkiWlpjA4QmVhY3aH8mEE VIbw3kMkgWQJh6oXXpxhJLSrCrcNJLSvTNXNm9sp4fODTQpMamEVWORBsjYD8R8UHk3i s8kL11fhIAYWNe3cTpRnfw+tRZ0vS0SZP6POQWzXTv2e8PdI02NNqCaePHAsDAF9zRlt +haQ== X-Gm-Message-State: AOAM530vRcYALnymEMa5seIZcWt124zz6nv99gtMccITYiRsLxR5B6kG /JiiIRsjeGxEUDVUe0wsSAm+Kc7WNVBwAnOXAfo= X-Google-Smtp-Source: ABdhPJzPlyWmeSdVzKHbGdY+4dp+tW+DNd3dY0E3hgFCW24SyIEA3c5b9IvR4dNAHTpoXcfb6xSIpDfL+yN3eh9pTqY= X-Received: by 2002:a17:906:fc5:: with SMTP id c5mr3182527ejk.538.1612968678886; Wed, 10 Feb 2021 06:51:18 -0800 (PST) MIME-Version: 1.0 References: <20210210065925.22614-1-hxseverything@gmail.com> In-Reply-To: <20210210065925.22614-1-hxseverything@gmail.com> From: Willem de Bruijn Date: Wed, 10 Feb 2021 09:50:43 -0500 Message-ID: Subject: Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH To: huangxuesen Cc: David Miller , bpf , Daniel Borkmann , Network Development , LKML , huangxuesen , Willem de Bruijn , chengzhiyong , wangli , Alan Maguire Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 1:59 AM huangxuesen wrote: > > From: huangxuesen > > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets > encapsulation. But that is not appropriate when pushing Ethernet header. > > Add an option to further specify encap L2 type and set the inner_protocol > as ETH_P_TEB. > > Suggested-by: Willem de Bruijn > Signed-off-by: huangxuesen > Signed-off-by: chengzhiyong > Signed-off-by: wangli Thanks, this is exactly what I meant. Acked-by: Willem de Bruijn One small point regarding Signed-off-by: It is customary to capitalize family and given names.