From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH net-next v4 02/12] socket: move compat timeout handling into sock.c
Date: Fri, 1 Feb 2019 10:58:21 -0800 [thread overview]
Message-ID: <CAF=yD-LNyuywx4_ktyy3JcOd1pvFeKb1wyvDj59kbZoVLp4Lxg@mail.gmail.com> (raw)
In-Reply-To: <20190201154356.15536-3-deepa.kernel@gmail.com>
On Fri, Feb 1, 2019 at 7:48 AM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is a cleanup to prepare for the addition of 64-bit time_t
> in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems
> unnecessarily complex and error-prone, moving it all into the
> main setsockopt()/getsockopt() implementation requires half
> as much code and is easier to extend.
>
> 32-bit user space can now use old_timeval32 on both 32-bit
> and 64-bit machines, while 64-bit code can use
> __old_kernel_timeval.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
> @@ -1121,7 +1155,8 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
> int val;
> u64 val64;
> struct linger ling;
> - struct timeval tm;
> + struct old_timeval32 tm32;
> + struct __kernel_old_timeval tm;
nit: not used?
same for stm added later in the series
next prev parent reply other threads:[~2019-02-01 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 15:43 [PATCH net-next v4 00/12] net: y2038-safe socket timestamps Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 01/12] selftests: add missing include unistd Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 02/12] socket: move compat timeout handling into sock.c Deepa Dinamani
2019-02-01 18:58 ` Willem de Bruijn [this message]
2019-02-02 3:31 ` Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 03/12] arch: Use asm-generic/socket.h when possible Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 04/12] sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 05/12] arch: sparc: Override struct __kernel_old_timeval Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 06/12] socket: Use old_timeval types for socket timestamps Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 07/12] socket: Add struct __kernel_sock_timeval Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 08/12] socket: Add SO_TIMESTAMP[NS]_NEW Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 09/12] socket: Add SO_TIMESTAMPING_NEW Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 10/12] socket: Update timestamping Documentation Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 11/12] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes Deepa Dinamani
2019-02-01 15:43 ` [PATCH net-next v4 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW Deepa Dinamani
2019-02-01 18:59 ` [PATCH net-next v4 00/12] net: y2038-safe socket timestamps Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-LNyuywx4_ktyy3JcOd1pvFeKb1wyvDj59kbZoVLp4Lxg@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).