From: Sumit Garg <sumit.garg@linaro.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
linux-security-module@vger.kernel.org, dhowells@redhat.com,
Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca,
jejb@linux.ibm.com, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mimi Zohar <zohar@linux.ibm.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>
Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code
Date: Thu, 8 Aug 2019 18:51:38 +0530 [thread overview]
Message-ID: <CAFA6WYN-6MpP2TZQEz49BmjSQiMSqghVFWRZCCY0o1UVad1AFw@mail.gmail.com> (raw)
In-Reply-To: <20190807190320.th4sbnsnmwb7myzx@linux.intel.com>
On Thu, 8 Aug 2019 at 00:33, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
>
> On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote:
> > Move TPM2 trusted keys code to trusted keys subsystem.
>
> Missing a long description. The reason is that it is better consolidate
> all trusted keys code to a single location so that it can be maintained
> sanely and it should be stated here.
Sure will extend the description.
>
> > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>
> I would suggest adding at least two commits before this:
>
> - A commit that just exports tpm_buf stuff and TPM2 constants to
> include/linux
Okay, will create a separate patch for this.
> - A commit that just changes the existing TPM 1.x trusted keys
> code to use tpm_buf.
It seems to be a functional change which I think requires proper unit
testing. I am afraid that I don't posses a TPM device to test this and
also very less conversant with tpm_buf code.
So what I have done here is to rename existing TPM 1.x trusted keys
code to use tpm1_buf.
And I would be happy to integrate a tested patch if anyone familiar
could work on this.
-Sumit
>
> These should be before the current 1/3 commit.
>
> /Jarkko
next prev parent reply other threads:[~2019-08-08 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 13:37 [RFC/RFT v3 0/3] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 1/3] KEYS: trusted: create trusted keys subsystem Sumit Garg
2019-08-07 18:59 ` Jarkko Sakkinen
2019-08-08 12:26 ` Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code Sumit Garg
2019-08-06 13:43 ` Greg KH
2019-08-06 13:55 ` Sumit Garg
2019-08-07 19:03 ` Jarkko Sakkinen
2019-08-08 13:21 ` Sumit Garg [this message]
2019-08-08 15:15 ` Jarkko Sakkinen
2019-08-13 7:59 ` Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 3/3] KEYS: trusted: Add generic trusted keys framework Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFA6WYN-6MpP2TZQEz49BmjSQiMSqghVFWRZCCY0o1UVad1AFw@mail.gmail.com \
--to=sumit.garg@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=casey@schaufler-ca.com \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=tee-dev@lists.linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).