From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCC6C433E7 for ; Tue, 13 Oct 2020 11:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E14A220E65 for ; Tue, 13 Oct 2020 11:29:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X04ds4sw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbgJML3B (ORCPT ); Tue, 13 Oct 2020 07:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgJML3A (ORCPT ); Tue, 13 Oct 2020 07:29:00 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78534C0613D5 for ; Tue, 13 Oct 2020 04:29:00 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id c21so3616203ljj.0 for ; Tue, 13 Oct 2020 04:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0fe/rUPknWKjJHQfNjjMwuy0QlI3MJO2qD6YuDAy3qE=; b=X04ds4sw8SJNth6bHlu9JhQBVORr5yXBEE2b8Ov6oelmRazUaaNvD13K/TWOr7gyQd JtSzTS0gJ58yo0XSpqWYK1jQHHs/1WMjRF3P1PTENrCFQnIpZ5LiVmcWjBwm9T+zuUW2 SObFz5u+I6H+0434419wjVX6I/i1yL21PJbuy64REF65mLZ1WpcTPD35PS+JZGo92Aob y7O2v7+WQ3tMF6CnPEJ6hDtes809zD5L1gVi2BClPDgRPJuYgAoZ+OVqNAzmgAcalLmv x31cXMyUTmcv177luuQPMuZSOZ0Nom9Ci2+XWlhVqB1ZJJtUZ5FN0hrOTB5f9PgVV+6l pixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0fe/rUPknWKjJHQfNjjMwuy0QlI3MJO2qD6YuDAy3qE=; b=ZJsSqlpNdmI8DpyUi3CLxgrZShIy90jIKwWUpVkrMsfI/yNMfBOKN+b6e+fLAokpj5 A7x2RM7YIQCY7SYDLMdvoRcyVq+3e8TEGMuadp6vN5ya82W7G+xoDoxEbOxALF/Et1ZP JpFBRDC6sgKLhTm2Zw/ZJcsXiOjh7rXjbZgwx7b7H6oTHIxuP0M+DbgJcmXZcdSX81NP BUbErRax5kRN+lbrRi77hNbdtTYMYCzicLIoKAH3ngKqKXx3mL4rvFGscFB5MqxwJqCC 908KkR/fHsOznH6uQYbMhqrMpjJ86WVjh9JjX8Q0/LLLJtLgvz56//+FDuOsxUWD8dcX xfbw== X-Gm-Message-State: AOAM53078xdLDo8YCQQ2Jicb+qTeSZKlrAb88iwpxzNSlvZzHqpJ8C94 v8phJOvmge0J/GaRiHy9hiHHRwiNO4OEbicrBXnkvw== X-Google-Smtp-Source: ABdhPJxOlDao8AKCPBsqF7gTeRCRcVgwmk5ldXZOHlGJBEkPdQNH+RZ2Xsbw1swjy/dOe6vjwFkeKOoQY7F5HG7Wnf4= X-Received: by 2002:a2e:9d8d:: with SMTP id c13mr11367812ljj.339.1602588538772; Tue, 13 Oct 2020 04:28:58 -0700 (PDT) MIME-Version: 1.0 References: <1602065268-26017-1-git-send-email-sumit.garg@linaro.org> <1602065268-26017-5-git-send-email-sumit.garg@linaro.org> <20201013022157.GA47751@linux.intel.com> In-Reply-To: <20201013022157.GA47751@linux.intel.com> From: Sumit Garg Date: Tue, 13 Oct 2020 16:58:47 +0530 Message-ID: Subject: Re: [PATCH v7 4/4] MAINTAINERS: Add entry for TEE based Trusted Keys To: Jarkko Sakkinen Cc: Mimi Zohar , James Bottomley , David Howells , Jens Wiklander , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Casey Schaufler , Janne Karhunen , Daniel Thompson , Markus Wamser , Luke Hinds , "open list:ASYMMETRIC KEYS" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux Doc Mailing List , Linux Kernel Mailing List , linux-arm-kernel , op-tee@lists.trustedfirmware.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2020 at 07:52, Jarkko Sakkinen wrote: > > On Wed, Oct 07, 2020 at 03:37:48PM +0530, Sumit Garg wrote: > > Add MAINTAINERS entry for TEE based Trusted Keys framework. > > > > Signed-off-by: Sumit Garg > > Acked-by: Jarkko Sakkinen > > --- > > MAINTAINERS | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 48aff80..eb3d889 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9663,6 +9663,14 @@ F: include/keys/trusted-type.h > > F: include/keys/trusted_tpm.h > > F: security/keys/trusted-keys/ > > > > +KEYS-TRUSTED-TEE > > +M: Sumit Garg > > +L: linux-integrity@vger.kernel.org > > +L: keyrings@vger.kernel.org > > +S: Supported > > +F: include/keys/trusted_tee.h > > +F: security/keys/trusted-keys/trusted_tee.c > > + > > KEYS/KEYRINGS > > M: David Howells > > M: Jarkko Sakkinen > > -- > > 2.7.4 > > I'm sorry but I think I have changed my mind on this. This has been > spinning for a while and sometimes conclusions change over the time. > > I don't think that we really need a separate subsystem tag. I don't see it as a separate subsystem but rather a kind of underlying trust source (TEE) driver plugged into existing trusted keys subsystem. We could relate it to the RNG subsystem as well where there is a subsystem maintainer and specific driver maintainers. IMO, having a dedicated entry like this brings clarity in maintenance and in future we may have more trust sources like this added where everyone may not have access to all the trust sources to test. > I'd be for a > new M-entry or R-entry to the existing subsystem tag. It's essential to > have ack from someone with ARM and TEE knowledge but this way too heavy > for the purpose. If you still think otherwise then I am fine with a new M-entry for existing trusted keys subsystem as well. > > I also see it the most manageable if the trusted keys PR's come from a > single source. I echo here with you to have a single source for trusted keys PR's irrespective of whether we go with a separate trust source entry or update existing subsystem entry. -Sumit > > /Jarkko