From: Sumit Garg <sumit.garg@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
kgdb-bugreport@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Jason Wessel <jason.wessel@windriver.com>,
Douglas Anderson <dianders@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
stefan.saecherl@fau.de, qy15sije@cip.cs.fau.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] kgdb: Fix to kill breakpoints on initmem after boot
Date: Fri, 26 Feb 2021 15:02:09 +0530 [thread overview]
Message-ID: <CAFA6WYOij9-o35CVeZxi94+x8_cTpfXORmhn5YpfOgz0a-Ertg@mail.gmail.com> (raw)
In-Reply-To: <YDij234n3KAxWuXf@kroah.com>
On Fri, 26 Feb 2021 at 13:01, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 26, 2021 at 12:32:07PM +0530, Sumit Garg wrote:
> > + stable ML
> >
> > On Thu, 25 Feb 2021 at 21:26, Daniel Thompson
> > <daniel.thompson@linaro.org> wrote:
> > >
> > > On Wed, Feb 24, 2021 at 01:46:52PM +0530, Sumit Garg wrote:
> > > > Currently breakpoints in kernel .init.text section are not handled
> > > > correctly while allowing to remove them even after corresponding pages
> > > > have been freed.
> > > >
> > > > Fix it via killing .init.text section breakpoints just prior to initmem
> > > > pages being freed.
> > > >
> > > > Suggested-by: Doug Anderson <dianders@chromium.org>
> > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > >
> > > I saw Andrew has picked this one up. That's ok for me:
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> > >
> > > I already enriched kgdbtest to cover this (and they pass) so I guess
> > > this is also:
> > > Tested-by: Daniel Thompson <daniel.thompson@linaro.org>
> > >
> >
> > Thanks Daniel.
> >
> > > BTW this is not Cc:ed to stable and I do wonder if it crosses the
> > > threshold to be considered a fix rather than a feature. Normally I
> > > consider adding safety rails for kgdb to be a new feature but, in this
> > > case, the problem would easily ensnare an inexperienced developer who is
> > > doing nothing more than debugging their own driver (assuming they
> > > correctly marked their probe function as .init) so I think this weighs
> > > in favour of being a fix.
> > >
> >
> > Makes sense, Cc:ed stable.
>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
Thanks for the pointer, let me wait for this patch to land in Linus’
tree and then will drop a mail to stable@vger.kernel.org.
-Sumit
prev parent reply other threads:[~2021-02-26 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 8:16 [PATCH] kgdb: Fix to kill breakpoints on initmem after boot Sumit Garg
2021-02-24 18:09 ` Doug Anderson
2021-02-24 18:20 ` Andrew Morton
2021-02-26 6:56 ` Sumit Garg
2021-02-26 6:56 ` Sumit Garg
2021-02-25 15:56 ` Daniel Thompson
2021-02-26 7:02 ` Sumit Garg
2021-02-26 7:31 ` Greg KH
2021-02-26 9:32 ` Sumit Garg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFA6WYOij9-o35CVeZxi94+x8_cTpfXORmhn5YpfOgz0a-Ertg@mail.gmail.com \
--to=sumit.garg@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=qy15sije@cip.cs.fau.de \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=stefan.saecherl@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).