From: Sumit Garg <sumit.garg@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: kgdb-bugreport@lists.sourceforge.net,
Daniel Thompson <daniel.thompson@linaro.org>,
Jason Wessel <jason.wessel@windriver.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] kdb: Simplify kdb commands registration
Date: Thu, 4 Mar 2021 16:28:49 +0530 [thread overview]
Message-ID: <CAFA6WYPBka8B7WSD_v_UAHgRzDnK3V-OY91-M6SNKi=PpuK4Og@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=XQAWoAQ1kkyJ1QzhJgueCj0Lui1m5cxgPQXzThxm1SGw@mail.gmail.com>
Hi Doug,
On Tue, 2 Mar 2021 at 00:10, Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Tue, Feb 23, 2021 at 11:08 PM Sumit Garg <sumit.garg@linaro.org> wrote:
> >
> > Simplify kdb commands registration via using linked list instead of
> > static array for commands storage.
> >
> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > ---
> >
> > Changes in v5:
> > - Introduce new method: kdb_register_table() to register static kdb
> > main and breakpoint command tables instead of using statically
> > allocated commands.
> >
> > Changes in v4:
> > - Fix kdb commands memory allocation issue prior to slab being available
> > with an array of statically allocated commands. Now it works fine with
> > kgdbwait.
> > - Fix a misc checkpatch warning.
> > - I have dropped Doug's review tag as I think this version includes a
> > major fix that should be reviewed again.
> >
> > Changes in v3:
> > - Remove redundant "if" check.
> > - Pick up review tag from Doug.
> >
> > Changes in v2:
> > - Remove redundant NULL check for "cmd_name".
> > - Incorporate misc. comment.
> >
> > kernel/debug/kdb/kdb_bp.c | 81 ++++--
> > kernel/debug/kdb/kdb_main.c | 472 ++++++++++++++++++++-------------
> > kernel/debug/kdb/kdb_private.h | 3 +
> > 3 files changed, 343 insertions(+), 213 deletions(-)
>
> This looks good to me, thanks!
>
> Random notes:
>
> * We no longer check for "duplicate" commands for any of these
> statically allocated ones, but I guess that's fine.
Yeah, I think that check is redundant for static ones.
>
> * Presumably nothing outside of kdb/kgdb itself needs the ability to
> allocate commands statically. The only user I see now is ftrace and
> it looks like it runs late enough that it should be fine.
Agree.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
Thanks,
-Sumit
>
> -Doug
next prev parent reply other threads:[~2021-03-04 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 7:08 [PATCH v5] kdb: Simplify kdb commands registration Sumit Garg
2021-03-01 18:40 ` Doug Anderson
2021-03-04 10:58 ` Sumit Garg [this message]
2021-03-22 16:15 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFA6WYPBka8B7WSD_v_UAHgRzDnK3V-OY91-M6SNKi=PpuK4Og@mail.gmail.com' \
--to=sumit.garg@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).