From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3839C4320E for ; Sat, 28 Aug 2021 15:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAF4660E78 for ; Sat, 28 Aug 2021 15:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234544AbhH1Py7 (ORCPT ); Sat, 28 Aug 2021 11:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234518AbhH1Py5 (ORCPT ); Sat, 28 Aug 2021 11:54:57 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E6BC061756; Sat, 28 Aug 2021 08:54:06 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id b7so14579845edu.3; Sat, 28 Aug 2021 08:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b/FoITeBxXzYPYRycaXkbD+65bcxuT4OKmmdeFd0Jlo=; b=tf1iMB33IgOI69bWgXQProMFN2EETh3i67dsiFkKRxA9NLeh6/9xl9K6M9XrcT0iWy ZFmsotmZKl1z/y+aAEirsUT/PDgeEu+8hHkFNzANECFnmGiW+0JmHcbPc11mynjxEMic lNJs5eFdIb++dxvldt7ZZffeIIO+sfoUnEiMdH3ya0AdwMdLKbjGoioHQnPksF8rWGy+ 83Sqr5K2gOgs3X4dcCKS3G0SJb9Gqf0l3d2+xcFQbTi1S+hji3XJEbTYGmfhe8Ijqz20 L5bTfjfw96ZWjA53QnbUO3kfIBZIuW0kIJar0qXdpTEof5ekF1uolgO8nAqtZSW8Mi2r LeTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b/FoITeBxXzYPYRycaXkbD+65bcxuT4OKmmdeFd0Jlo=; b=iM+EssKdLi2BjXcPeQS8TogGLtKPFHpIwQoPlghCNljq7iwSMqCZ2KUU7nuCE6gAbn 8vF/xYFkQc8bWRUGTq9L00FwytCBxQAddENLP59BAvBESDI6az61GbhcVtv2sxawNeKI dFcDFypOhUmwo+ykX/1U0KdyHcDPy0oSJXvXUfHTUBXquJaLXO0yjp2XKsKioEQ0dTKV ExyhWQ0L19jlBTg8p4twyMe9OVHx02929CL6T08P3Ruflu+tjh76eIGQ8fhjoOTg5efl 6oNf8HDv9GrrHbNfsKo5qPiKdhSdaIRqvPgSLsyhg2iKs3r3gWbotIdj3bM9p9Ke+9JF uAFg== X-Gm-Message-State: AOAM531FB3fTRNAvd7T3M9eEmHMQlFCh81+RetzqlKVCv6a5VbYV68yZ hqNkZap7weZwmdd1gsGJfSeso9QXV9IyI/yqRA4= X-Google-Smtp-Source: ABdhPJytLQmCtHspjMyHBMTX4NFKx0mMPjNdfQW3zHxrQS2RLqSasQmOR6hdIPX9F0PdpYCg0LBEGk6dpFFYaYQFU7M= X-Received: by 2002:a50:e699:: with SMTP id z25mr15370730edm.130.1630166044946; Sat, 28 Aug 2021 08:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20210817041548.1276-1-linux.amoon@gmail.com> <20210817041548.1276-2-linux.amoon@gmail.com> In-Reply-To: <20210817041548.1276-2-linux.amoon@gmail.com> From: Martin Blumenstingl Date: Sat, 28 Aug 2021 17:53:54 +0200 Message-ID: Subject: Re: [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node To: Anand Moon Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Matt Corallo , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anand, sorry for the late reply I have three very small comments below, apart from these, this is looking good! On Tue, Aug 17, 2021 at 6:17 AM Anand Moon wrote: > > Add missing usb phy power node for usb node fix below warning. > P5V0 regulator supply input voltage range to USB host controller. > As described in the C1+ schematics, GPIO GPIOAO_5 is used to > enable input power to USB ports, set it to Active Low. I would phrase this last sentence as: "enable USB VBUS on the Micro-USB port using an active high signal" My idea here is to 1) clarify that it's about enabling USB VBUS only on the Micro-USB port and 2) use "active high" like the changes inside the patch itself > [ 1.260772] dwc2 c90c0000.usb: Looking up vbus-supply from device tree > [ 1.260784] dwc2 c90c0000.usb: Looking up vbus-supply property in > mode /soc/usb@c90c0000 failed > > Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host > controller on Odroid-C1/C1+ board) > please drop this empty line [...] > @@ -119,7 +136,6 @@ vcc_3v3: regulator-vcc-3v3 { > regulator-name = "VCC3V3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > - I don't think that we should make any VCC3V3 regulator changes in this patch so please keep this empty line as-is. Best regards, Martin