From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F95C61DA4 for ; Thu, 9 Mar 2023 21:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbjCIVli (ORCPT ); Thu, 9 Mar 2023 16:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjCIVlb (ORCPT ); Thu, 9 Mar 2023 16:41:31 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70AA2F865E; Thu, 9 Mar 2023 13:41:30 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id x3so12653473edb.10; Thu, 09 Mar 2023 13:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; t=1678398089; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AR1b3GABOQLV0P4AFqJgRYAPV/jd6YPCXWJ10JJ7GQA=; b=bVV9zB4PWz/GixwLQd9wj07swwOT/5L8l7AYGlJV39XCgfm5cBj2R76j8n/krnPBNF e6HICDvbiaQ1x+XAwjDG08vSRQer/+wTj3q6MkzNMSS3saTFHaS1S2G6cRX2Utbv2eTh tWb/JB6UcF+rBSP568bMYcbPnQ2dtX4rPGjdmatlyv7z3GqmrqLzsZq1x3SirUPCsaHu LnmAjGvKRmkVtoqaSL09XqXrDe58MJ1OEVF6In8g1AEIakrXwIsRWGh7HbBFoPpaCO4W c/kYP+I4vqJB6PSZdBea/WNQx9UYjXpcAk2AfzMmwcdOGOGificFynYzuK2ISXl506in VU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678398089; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AR1b3GABOQLV0P4AFqJgRYAPV/jd6YPCXWJ10JJ7GQA=; b=CJGXnowa2LD3G+VU8YEnivLx482evwBa2s8h8CdvMcizA+ghKjp8+zYThGkjF3rXYp 6jtejzQ5abq6EIW0JmzQvAN9xX0vR4LcPRON+DOmvlPQtWHx8N1jgnbdguf/XGL8z8Pg LkMpV2erV/Wh+1dzQL5ZeVTfSj/tlIR/i/22hTNL2/5BLyypZgwYt7tarGyOZKUjh+Rh g6CE/EadqNt+93jC0II+FAAMHOjP2MIehiUoUlUPe52qYbOaKpMZpUqI9KH5W+ML16D5 nugd57XGd4nvXaRuYrGIE7vkFWvSDqEk9C2p/ajAgNt6YFEylCeUxbZNXgeruYrgswsI kGCA== X-Gm-Message-State: AO0yUKUlxZGNgl7QF/iD/qpfXHk2sTQhmsih8UROTDqntlHCmxNMF/8t USl4MgsADbtW9nMrHFvBstqRURUysrNXRMOZKMw= X-Google-Smtp-Source: AK7set+iplnwVXlr7+v6coCIsyOhlACFhoeoFarKEw4JA1Y6NwVDADLB4DScaPTQyE9qNP613oIHrbUsSOajkyzvD+I= X-Received: by 2002:a17:906:ce38:b0:8b1:30da:b585 with SMTP id sd24-20020a170906ce3800b008b130dab585mr12117490ejb.6.1678398088913; Thu, 09 Mar 2023 13:41:28 -0800 (PST) MIME-Version: 1.0 References: <20230306103533.4915-1-johan+linaro@kernel.org> In-Reply-To: <20230306103533.4915-1-johan+linaro@kernel.org> From: Martin Blumenstingl Date: Thu, 9 Mar 2023 22:41:18 +0100 Message-ID: Subject: Re: [PATCH] drm/meson: fix missing component unbind on bind errors To: Johan Hovold , Neil Armstrong Cc: David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, thanks for your patch! On Mon, Mar 6, 2023 at 11:35=E2=80=AFAM Johan Hovold wrote: [...] > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev= , bool has_components) > > ret =3D meson_encoder_hdmi_init(priv); I'm wondering if component_bind_all() can be moved further down. Right now it's between meson_encoder_cvbs_init() and meson_encoder_hdmi_init(). So it seems that encoders don't rely on component registration. Unfortunately I am also not familiar with this and I'm hoping that Neil can comment on this. Best regards, Martin