From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
f.fainelli@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5] net: phy: intel-xway: Add RGMII internal delay configuration
Date: Mon, 12 Jul 2021 13:12:20 +0200 [thread overview]
Message-ID: <CAFBinCCMtBxvdpkiiFbB1xvy4qhCTb-hU5VJEMQdHDDAYWq=5g@mail.gmail.com> (raw)
In-Reply-To: <20210712072413.11490-1-ms@dev.tdt.de>
On Mon, Jul 12, 2021 at 9:24 AM Martin Schiller <ms@dev.tdt.de> wrote:
>
> This adds the possibility to configure the RGMII RX/TX clock skew via
> devicetree.
>
> Simply set phy mode to "rgmii-id", "rgmii-rxid" or "rgmii-txid" and add
> the "rx-internal-delay-ps" or "tx-internal-delay-ps" property to the
> devicetree.
>
> Furthermore, a warning is now issued if the phy mode is configured to
> "rgmii" and an internal delay is set in the phy (e.g. by pin-strapping),
> as in the dp83867 driver.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Thanks for this updated version!
Everything's looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
next prev parent reply other threads:[~2021-07-12 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 7:24 [PATCH net-next v5] net: phy: intel-xway: Add RGMII internal delay configuration Martin Schiller
2021-07-12 9:54 ` Hauke Mehrtens
2021-07-12 11:12 ` Martin Blumenstingl [this message]
2021-07-12 11:22 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCCMtBxvdpkiiFbB1xvy4qhCTb-hU5VJEMQdHDDAYWq=5g@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).