From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Mathias Kresin <dev@kresin.me>, Hauke Mehrtens <hauke@hauke-m.de>
Cc: john@phrozen.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts
Date: Sun, 8 Apr 2018 23:30:27 +0200 [thread overview]
Message-ID: <CAFBinCCQO4B3a+ft7H1mMgfaS4=qSnmern3ZqD3QGt0815Oh0w@mail.gmail.com> (raw)
In-Reply-To: <1523176203-18926-1-git-send-email-dev@kresin.me>
On Sun, Apr 8, 2018 at 10:30 AM, Mathias Kresin <dev@kresin.me> wrote:
> While doing a global software reset, these bits are not cleared and let
> some bootloader fail to initialise the GPHYs. The bootloader don't
> expect the GPHYs in reset, as they aren't during power on.
>
> The asserts were a workaround for a wrong syscon-reboot mask. With a
> mask set which includes the GPHY resets, these resets aren't required
> any more.
>
> Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU syscon-mfd")
> Cc: stable@vger.kernel.org # 4.14+
> Signed-off-by: Mathias Kresin <dev@kresin.me>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
thank you Mathias!
@Hauke: maybe you can also review this and give feedback?
> ---
> drivers/soc/lantiq/gphy.c | 34 ----------------------------------
> 1 file changed, 34 deletions(-)
>
> diff --git a/drivers/soc/lantiq/gphy.c b/drivers/soc/lantiq/gphy.c
> index 8d86594..8c31ae7 100644
> --- a/drivers/soc/lantiq/gphy.c
> +++ b/drivers/soc/lantiq/gphy.c
> @@ -30,7 +30,6 @@ struct xway_gphy_priv {
> struct clk *gphy_clk_gate;
> struct reset_control *gphy_reset;
> struct reset_control *gphy_reset2;
> - struct notifier_block gphy_reboot_nb;
> void __iomem *membase;
> char *fw_name;
> };
> @@ -64,24 +63,6 @@ static const struct of_device_id xway_gphy_match[] = {
> };
> MODULE_DEVICE_TABLE(of, xway_gphy_match);
>
> -static struct xway_gphy_priv *to_xway_gphy_priv(struct notifier_block *nb)
> -{
> - return container_of(nb, struct xway_gphy_priv, gphy_reboot_nb);
> -}
> -
> -static int xway_gphy_reboot_notify(struct notifier_block *reboot_nb,
> - unsigned long code, void *unused)
> -{
> - struct xway_gphy_priv *priv = to_xway_gphy_priv(reboot_nb);
> -
> - if (priv) {
> - reset_control_assert(priv->gphy_reset);
> - reset_control_assert(priv->gphy_reset2);
> - }
> -
> - return NOTIFY_DONE;
> -}
> -
> static int xway_gphy_load(struct device *dev, struct xway_gphy_priv *priv,
> dma_addr_t *dev_addr)
> {
> @@ -205,14 +186,6 @@ static int xway_gphy_probe(struct platform_device *pdev)
> reset_control_deassert(priv->gphy_reset);
> reset_control_deassert(priv->gphy_reset2);
>
> - /* assert the gphy reset because it can hang after a reboot: */
> - priv->gphy_reboot_nb.notifier_call = xway_gphy_reboot_notify;
> - priv->gphy_reboot_nb.priority = -1;
> -
> - ret = register_reboot_notifier(&priv->gphy_reboot_nb);
> - if (ret)
> - dev_warn(dev, "Failed to register reboot notifier\n");
> -
> platform_set_drvdata(pdev, priv);
>
> return ret;
> @@ -224,17 +197,10 @@ static int xway_gphy_remove(struct platform_device *pdev)
> struct xway_gphy_priv *priv = platform_get_drvdata(pdev);
> int ret;
>
> - reset_control_assert(priv->gphy_reset);
> - reset_control_assert(priv->gphy_reset2);
> -
> iowrite32be(0, priv->membase);
>
> clk_disable_unprepare(priv->gphy_clk_gate);
>
> - ret = unregister_reboot_notifier(&priv->gphy_reboot_nb);
> - if (ret)
> - dev_warn(dev, "Failed to unregister reboot notifier\n");
> -
> return 0;
> }
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-04-08 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 8:30 [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts Mathias Kresin
2018-04-08 21:30 ` Martin Blumenstingl [this message]
2018-04-22 19:18 ` Hauke Mehrtens
2018-05-21 16:39 ` James Hogan
2018-05-24 12:07 ` James Hogan
2018-05-25 10:12 ` Mathias Kresin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCCQO4B3a+ft7H1mMgfaS4=qSnmern3ZqD3QGt0815Oh0w@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=dev@kresin.me \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).