From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
Date: Sat, 20 Aug 2022 19:25:52 +0200 [thread overview]
Message-ID: <CAFBinCCbjF_mkV+EaOtC0g_YbtX9TzBEN5fRJ_MiPaie5hxCwQ@mail.gmail.com> (raw)
In-Reply-To: <20220819060801.10443-18-jinpu.wang@ionos.com>
Hello Jack,
first of all: thank you for this patch!
On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote:
[...]
> @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq)
>
> dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len,
Does it also make sense to change the type of the dma_len variable
from (signed) int to "unsigned int" (a few lines above)?
Best regards,
Martin
next prev parent reply other threads:[~2022-08-20 17:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
2022-08-22 5:07 ` Dan Carpenter
2022-08-22 9:58 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
2022-08-19 22:19 ` Kees Cook
2022-08-21 11:46 ` Leon Romanovsky
2022-08-22 5:11 ` Dan Carpenter
2022-08-19 6:07 ` [PATCH v1 03/19] HSI: omap_ssi_port: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
2022-08-23 7:49 ` Christophe Kerello
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg Jack Wang
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 06/19] usb/hcd: Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
2022-08-26 8:13 ` Linus Walleij
2022-08-26 11:06 ` Herbert Xu
2022-08-26 12:04 ` LABBE Corentin
2022-08-26 12:08 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 08/19] crypto: sahara: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 09/19] crypto: qce: Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: " Jack Wang
2022-08-26 12:46 ` LABBE Corentin
2022-08-19 6:07 ` [PATCH v1 11/19] crypto: allwinner: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 12/19] crypto: ccree: " Jack Wang
2022-08-21 9:44 ` Gilad Ben-Yossef
2022-08-19 6:07 ` [PATCH v1 13/19] intel_th: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg Jack Wang
2022-08-21 5:57 ` Christoph Hellwig
2022-08-22 5:12 ` Jinpu Wang
2022-08-22 6:25 ` Christoph Hellwig
2022-08-22 7:10 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 15/19] nvme-fc: Fix the error check for dma_map_sg Jack Wang
2022-08-19 6:07 ` [PATCH v1 16/19] scsi/qlogicpti: Fix dma_map_sg check Jack Wang
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
2022-08-20 17:25 ` Martin Blumenstingl [this message]
2022-08-22 5:15 ` Jinpu Wang
2022-08-19 6:08 ` [PATCH v1 18/19] mmc: jz4740_mmc: " Jack Wang
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
2022-08-21 11:42 ` Leon Romanovsky
2022-08-22 18:20 ` Jakub Kicinski
2022-08-24 14:39 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCbjF_mkV+EaOtC0g_YbtX9TzBEN5fRJ_MiPaie5hxCwQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=jinpu.wang@ionos.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).