From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
khilman@baylibre.com, mark.rutland@arm.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, baylibre-upstreaming@groups.io,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] crypto: amlogic: Add crypto accelerator for amlogic GXL
Date: Sat, 27 Jul 2019 14:17:38 +0200 [thread overview]
Message-ID: <CAFBinCD7pgUaBJgeGHTOu-uZRA9a6K2kxPsu+huKe23wcnKPoA@mail.gmail.com> (raw)
In-Reply-To: <1564083776-20540-3-git-send-email-clabbe@baylibre.com>
Hi Corentin,
it's great to see you working on this :)
On Thu, Jul 25, 2019 at 9:45 PM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> This patch adds support for the amlogic GXL cryptographic offloader present
> on GXL SoCs.
>
> This driver supports AES cipher in CBC/ECB mode.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/crypto/Kconfig | 2 +
> drivers/crypto/Makefile | 1 +
> drivers/crypto/amlogic/Kconfig | 24 ++
> drivers/crypto/amlogic/Makefile | 2 +
> drivers/crypto/amlogic/amlogic-cipher.c | 358 ++++++++++++++++++++++++
> drivers/crypto/amlogic/amlogic-core.c | 326 +++++++++++++++++++++
> drivers/crypto/amlogic/amlogic.h | 172 ++++++++++++
> 7 files changed, 885 insertions(+)
> create mode 100644 drivers/crypto/amlogic/Kconfig
> create mode 100644 drivers/crypto/amlogic/Makefile
> create mode 100644 drivers/crypto/amlogic/amlogic-cipher.c
> create mode 100644 drivers/crypto/amlogic/amlogic-core.c
> create mode 100644 drivers/crypto/amlogic/amlogic.h
there are two different crypto IPs on Amlogic SoCs:
- GXL and newer use the "BLKMV" crypto IP
- GXBB, Meson8/Meson8b/Meson8m2 (and probably older SoCs) use the
"NDMA" crypto IP
personally I think it makes sense to either have the IP name (blkmv)
or SoC name (GXL) in the file or directory names as well as being
consistent with that in the Kconfig option names
(I have no experience with the crypto framework so I cannot comment on
the driver implementation itself)
Martin
next prev parent reply other threads:[~2019-07-27 12:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 19:42 [PATCH 0/4] crypto: add amlogic crypto offloader driver Corentin Labbe
2019-07-25 19:42 ` [PATCH 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto Corentin Labbe
2019-07-25 22:55 ` Rob Herring
2019-07-26 11:07 ` LABBE Corentin
[not found] ` <15B4F061F360B2F0.8182@groups.io>
2019-07-26 12:54 ` LABBE Corentin
2019-07-25 19:42 ` [PATCH 2/4] crypto: amlogic: Add crypto accelerator for amlogic GXL Corentin Labbe
2019-07-27 12:17 ` Martin Blumenstingl [this message]
2019-08-01 12:46 ` LABBE Corentin
2019-07-25 19:42 ` [PATCH 3/4] MAINTAINERS: Add myself as maintainer of amlogic crypto Corentin Labbe
2019-07-25 19:42 ` [PATCH 4/4] ARM64: dts: amlogic: adds crypto hardware node Corentin Labbe
2019-07-28 18:48 ` [PATCH 0/4] crypto: add amlogic crypto offloader driver Eric Biggers
2019-07-28 19:42 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCD7pgUaBJgeGHTOu-uZRA9a6K2kxPsu+huKe23wcnKPoA@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=baylibre-upstreaming@groups.io \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).